From 27c765f6bd6039c63d6b6bcbaf14db264c28b415 Mon Sep 17 00:00:00 2001
From: Dan Percic <dan@devplant.ro>
Date: Thu, 5 Jan 2023 16:02:37 +0200
Subject: [PATCH] Remove custom url encoder (angular fixed it)

---
 src/lib/services/generic.service.ts |  4 ++--
 src/lib/utils/http-encoder.ts       | 18 ------------------
 src/lib/utils/index.ts              |  1 -
 3 files changed, 2 insertions(+), 21 deletions(-)
 delete mode 100644 src/lib/utils/http-encoder.ts

diff --git a/src/lib/services/generic.service.ts b/src/lib/services/generic.service.ts
index 9517f03..8e121fc 100644
--- a/src/lib/services/generic.service.ts
+++ b/src/lib/services/generic.service.ts
@@ -1,7 +1,7 @@
 import { HttpClient, HttpEvent, HttpParams } from '@angular/common/http';
 import { inject } from '@angular/core';
 import { Observable } from 'rxjs';
-import { CustomHttpUrlEncodingCodec, HeadersConfiguration, List, RequiredParam, Validate } from '../utils';
+import { HeadersConfiguration, List, RequiredParam, Validate } from '../utils';
 import { map, tap } from 'rxjs/operators';
 
 const ROOT_CHANGES_KEY = 'root';
@@ -132,7 +132,7 @@ export abstract class GenericService<I> {
     }
 
     protected _queryParams(queryParams?: List<QueryParam>): HttpParams {
-        let queryParameters = new HttpParams({ encoder: new CustomHttpUrlEncodingCodec() });
+        let queryParameters = new HttpParams();
         queryParams?.forEach(param => {
             if (param?.value !== undefined && param?.value !== null) {
                 queryParameters = queryParameters.append(param.key, param.value);
diff --git a/src/lib/utils/http-encoder.ts b/src/lib/utils/http-encoder.ts
deleted file mode 100644
index 892cfe3..0000000
--- a/src/lib/utils/http-encoder.ts
+++ /dev/null
@@ -1,18 +0,0 @@
-import { HttpUrlEncodingCodec } from '@angular/common/http';
-
-/**
- * CustomHttpUrlEncodingCodec
- * Fix plus sign (+) not encoding, so sent as blank space
- * See: https://github.com/angular/angular/issues/11058#issuecomment-247367318
- */
-export class CustomHttpUrlEncodingCodec extends HttpUrlEncodingCodec {
-    encodeKey(k: string): string {
-        const kk = super.encodeKey(k);
-        return kk.replace(/\+/gi, '%2B');
-    }
-
-    encodeValue(v: string): string {
-        const vv = super.encodeValue(v);
-        return vv.replace(/\+/gi, '%2B');
-    }
-}
diff --git a/src/lib/utils/index.ts b/src/lib/utils/index.ts
index b84a77f..6864a2e 100644
--- a/src/lib/utils/index.ts
+++ b/src/lib/utils/index.ts
@@ -9,7 +9,6 @@ export * from './decorators/required.decorator';
 export * from './decorators/required-param.decorator';
 export * from './decorators/debounce.decorator';
 export * from './decorators/on-change.decorator';
-export * from './http-encoder';
 export * from './types/iqser-types';
 export * from '../translations/pruning-translation-loader';
 export * from './custom-route-reuse.strategy';