diff --git a/src/lib/listing/listing-component.directive.ts b/src/lib/listing/listing-component.directive.ts index 986ec58..bc20fae 100644 --- a/src/lib/listing/listing-component.directive.ts +++ b/src/lib/listing/listing-component.directive.ts @@ -20,11 +20,11 @@ export abstract class ListingComponent extends AutoUnsubscri readonly noMatch$ = this._noMatch$; readonly noContent$ = this._noContent$; readonly sortedDisplayedEntities$ = this._sortedDisplayedEntities$; + readonly routerLinkFn?: (entity: T) => string | string[]; // TODO: These should be somewhere in table listing, not generic listing abstract readonly tableColumnConfigs: readonly TableColumnConfig[]; - readonly tableHeaderLabel?: string; - readonly routerLinkFn?: (entity: T) => string | string[]; + abstract readonly tableHeaderLabel: string; /** * Key used in the *trackBy* function with **ngFor* or **cdkVirtualFor* diff --git a/src/lib/listing/models/table-column-config.model.ts b/src/lib/listing/models/table-column-config.model.ts index 70ba78f..34679b8 100644 --- a/src/lib/listing/models/table-column-config.model.ts +++ b/src/lib/listing/models/table-column-config.model.ts @@ -10,7 +10,7 @@ export interface TableColumnConfig { readonly rightIconTooltip?: string; readonly notTranslatable?: boolean; readonly width?: string; - readonly template?: TemplateRef; // TODO: make required + readonly template: TemplateRef; readonly extra?: unknown; last?: boolean; } diff --git a/src/lib/listing/table/table.component.ts b/src/lib/listing/table/table.component.ts index ab1d0a6..41225a3 100644 --- a/src/lib/listing/table/table.component.ts +++ b/src/lib/listing/table/table.component.ts @@ -46,7 +46,7 @@ export class TableComponent implements OnInit { @Input() itemMouseLeaveFn?: (entity: T) => void; routerLinkFn?: (entity: T) => string | string[]; tableColumnConfigs!: readonly TableColumnConfig[]; - tableHeaderLabel?: string; // todo not optional + tableHeaderLabel!: string; @ViewChild(CdkVirtualScrollViewport, { static: true }) readonly scrollViewport!: CdkVirtualScrollViewport; constructor(