From bfaae5adf6522a099a55c7f3546dee3b542c4c33 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adina=20=C8=9Aeudan?= Date: Thu, 19 Oct 2023 21:58:09 +0300 Subject: [PATCH] Use disabled instead of canEditInput in dynamic input --- .../inputs/dynamic-input/dynamic-input.component.html | 9 +++------ src/lib/inputs/dynamic-input/dynamic-input.component.ts | 8 +++----- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/src/lib/inputs/dynamic-input/dynamic-input.component.html b/src/lib/inputs/dynamic-input/dynamic-input.component.html index c9c45b5..6f53cb6 100644 --- a/src/lib/inputs/dynamic-input/dynamic-input.component.html +++ b/src/lib/inputs/dynamic-input/dynamic-input.component.html @@ -5,10 +5,9 @@ @@ -22,9 +21,8 @@ (ngModelChange)="onChange($event)" *ngIf="isText" [(ngModel)]="input" - [disabled]="!canEditInput" + [disabled]="disabled" [id]="id" - [name]="name" [placeholder]="placeholder || ''" iqserStopPropagation type="text" @@ -34,9 +32,8 @@ (ngModelChange)="onChange($event)" *ngIf="isNumber" [(ngModel)]="input" - [disabled]="!canEditInput" + [disabled]="disabled" [id]="id" - [name]="name" iqserStopPropagation type="number" /> diff --git a/src/lib/inputs/dynamic-input/dynamic-input.component.ts b/src/lib/inputs/dynamic-input/dynamic-input.component.ts index 9521fcb..c4fd2c3 100644 --- a/src/lib/inputs/dynamic-input/dynamic-input.component.ts +++ b/src/lib/inputs/dynamic-input/dynamic-input.component.ts @@ -19,7 +19,7 @@ export type InputType = keyof typeof InputTypes; type DynamicInput = number | string | Date; @Component({ - selector: 'iqser-dynamic-input [type]', + selector: 'iqser-dynamic-input', templateUrl: './dynamic-input.component.html', styleUrls: ['./dynamic-input.component.scss'], changeDetection: ChangeDetectionStrategy.OnPush, @@ -40,13 +40,11 @@ type DynamicInput = number | string | Date; }) export class DynamicInputComponent extends FormFieldComponent { @Input() label?: string; - @Input() type!: InputType; + @Input({ required: true }) type!: InputType; @Input() placeholder?: string; @Input() id?: string; - @Input() name?: string; - @Input() classList?: string = ''; + @Input() classList = ''; @Input() input!: DynamicInput; - @Input() canEditInput = true; @Output() readonly closedDatepicker = new EventEmitter(); get isDate() {