From c16328aa38adcbe68fd20cda2512308ccb8f36f0 Mon Sep 17 00:00:00 2001
From: Dan Percic <dan@devplant.ro>
Date: Thu, 14 Oct 2021 23:00:39 +0300
Subject: [PATCH] check query params for null or undefined

---
 src/lib/services/generic.service.ts | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/lib/services/generic.service.ts b/src/lib/services/generic.service.ts
index 0540e77..410766d 100644
--- a/src/lib/services/generic.service.ts
+++ b/src/lib/services/generic.service.ts
@@ -40,11 +40,7 @@ export abstract class GenericService<I> {
     }
 
     @Validate()
-    delete(
-        @RequiredParam() body: unknown,
-        modelPath = this._defaultModelPath,
-        queryParams?: List<QueryParam>,
-    ): Observable<unknown> {
+    delete(@RequiredParam() body: unknown, modelPath = this._defaultModelPath, queryParams?: List<QueryParam>): Observable<unknown> {
         let path = `/${encodeURI(modelPath)}`;
 
         if (typeof body === 'string') {
@@ -121,7 +117,7 @@ export abstract class GenericService<I> {
     protected _queryParams(queryParams?: List<QueryParam>): HttpParams {
         let queryParameters = new HttpParams({ encoder: new CustomHttpUrlEncodingCodec() });
         queryParams?.forEach(param => {
-            if (param.value) {
+            if (param?.value !== undefined && param?.value !== null) {
                 queryParameters = queryParameters.append(param.key, param.value);
             }
         });