RED-4590 - sonar fixes

src/lib/help-mode/help-button/help-button.component.ts

@@ -5,7 +5,6 @@ import { HelpModeService } from '../index';
 @Component({
     selector: 'iqser-help-button',
     templateUrl: './help-button.component.html',
-    styleUrls: ['./help-button.component.scss'],
 })
 export class HelpButtonComponent implements OnInit, OnDestroy {
     @Input() helpButtonKey?: string;

src/lib/listing/page-header/page-header.component.ts

@@ -55,7 +55,7 @@ export class PageHeaderComponent<T extends IListable> {
         this.searchService.reset();
     }
 
-    trackByLabel<K extends { label?: string }>(index: number, item: K): string | undefined {
+    trackByLabel<K extends { label?: string }>(_index: number, item: K): string | undefined {
         return item.label;
     }
 }

src/lib/listing/services/listing.service.ts

@@ -117,7 +117,7 @@ export class ListingService<E extends IListable> {
         if (currentEntityIdx === -1) {
             return this.setSelected([...this.selected, entity]);
         }
-        this.setSelected(this.selected.filter((el, idx) => idx !== currentEntityIdx));
+        this.setSelected(this.selected.filter((_el, idx) => idx !== currentEntityIdx));
     }
 
     deselect(entities: E | E[]) {

src/lib/listing/table/table.component.ts

@@ -24,7 +24,6 @@ const SCROLLBAR_WIDTH = 11;
 @Component({
     selector: 'iqser-table [tableColumnConfigs] [itemSize]',
     templateUrl: './table.component.html',
-    styleUrls: ['./table.component.scss'],
     changeDetection: ChangeDetectionStrategy.OnPush,
 })
 export class TableComponent<T extends IListable> extends AutoUnsubscribe implements OnChanges {

src/lib/loading/full-page-loading-indicator/full-page-loading-indicator.component.ts

@@ -4,7 +4,6 @@ import { LoadingService } from '../loading.service';
 @Component({
     selector: 'iqser-full-page-loading-indicator',
     templateUrl: './full-page-loading-indicator.component.html',
-    styleUrls: ['./full-page-loading-indicator.component.scss'],
     changeDetection: ChangeDetectionStrategy.OnPush,
 })
 export class FullPageLoadingIndicatorComponent {

src/lib/misc/hidden-action/hidden-action.component.ts

@@ -4,7 +4,6 @@ import { BehaviorSubject } from 'rxjs';
 @Component({
     selector: 'iqser-hidden-action',
     templateUrl: './hidden-action.component.html',
-    styleUrls: ['./hidden-action.component.scss'],
     changeDetection: ChangeDetectionStrategy.OnPush,
 })
 export class HiddenActionComponent {

src/lib/misc/side-nav/side-nav.component.ts

@@ -4,7 +4,6 @@ import { Required } from '../../utils';
 @Component({
     selector: 'iqser-side-nav',
     templateUrl: './side-nav.component.html',
-    styleUrls: ['./side-nav.component.scss'],
     changeDetection: ChangeDetectionStrategy.OnPush,
 })
 export class SideNavComponent {

src/lib/misc/toast/toast.component.ts

@@ -4,7 +4,6 @@ import { ToasterActions, ToasterOptions } from '../../services';
 
 @Component({
     templateUrl: './toast.component.html',
-    styleUrls: ['./toast.component.scss'],
     changeDetection: ChangeDetectionStrategy.OnPush,
 })
 export class ToastComponent extends Toast {

src/lib/utils/functions.ts

@@ -34,7 +34,7 @@ export function toNumber(str: string): number {
 }
 
 export function trackByFactory<T extends ITrackable>() {
-    return (index: number, item: T): string => item.id;
+    return (_index: number, item: T): string => item.id;
 }
 
 export function hasFormChanged(form: UntypedFormGroup, initialFormValue: Record<string, string>): boolean {
@@ -107,7 +107,7 @@ export function deepDiffObj(base: Record<string, unknown>, object: Record<string
         }
     });
     // map removed fields to undefined
-    forOwn(base, (value: any, key: string) => {
+    forOwn(base, (_value: any, key: string) => {
         if (!has(object, key)) {
             res[key] = undefined;
         }