Marmelator/image-classification-service
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 29 Wiki Activity

Refactoring

Browse Source
This commit is contained in:
Matthias Bisping 2023-02-07 11:44:01 +01:00
parent 092069221a
commit cb1c461049
1 changed files with 25 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
image_prediction/image_extractor/extractors/parsable.py
View File

@ -147,27 +147,35 @@ def make_eithered_image_metadata_pair(image: Either, metadata: Either) -> Either
def context(value): def context(value):
return {"reason": value, "metadata": metadata.either(bottom, identity)} return {"reason": value, "metadata": metadata.either(bottom, identity)}
# What is most readable? # Explicitly we are doing the following. (1) and (2) are equivalent.
# 1)
# return Either.apply(make_image_metadata_pair).to_arguments(image, metadata).either(left(context), right(identity))
# 2)
# m (a -> b -> c) -> m a -> m b -> m c
# return Right(make_image_metadata_pair).amap(image).amap(metadata).either(left(context), right(identity))
# 3)
# a := Image # a := Image
# b := Metadata # b := Metadata
# c := ImageMetadataPair # c := ImageMetadataPair
return (
image.bind(right(make_image_metadata_pair)) # m a >>= m (a -> b -> c) -> m (b -> c) # 1)
.amap(metadata) # m (b -> c) <*> m b -> m c # return (
.either( # Right(make_image_metadata_pair) # m (a -> b -> c)
left(context), # .amap(image) # m (a -> b -> c) $ m a = m (b -> c)
right(identity), # .amap(metadata) # m (b -> c) $ m b = m c
) # .either(
) # left(context),
# right(identity),
# )
# )
# 2)
# return (
# image.bind(right(make_image_metadata_pair)) # m a >>= m (a -> b -> c) = m (b -> c)
# .amap(metadata) # m (b -> c) <*> m b = m c
# .either(
# left(context),
# right(identity),
# )
# )
# Syntactic sugar variant:
return Either.apply(make_image_metadata_pair).to_arguments(image, metadata).either(left(context), right(identity))
@curry(2) @curry(2)