Merge in RR/image-prediction from RED-6084-adhoc-scanned-pages-filtering-refactoring to master
Squashed commit of the following:
commit bd6d83e7363b1c1993babcceb434110a6312c645
Author: Matthias Bisping <matthias.bisping@axbit.com>
Date: Thu Feb 9 16:08:25 2023 +0100
Tweak logging
commit 55bdd48d2a3462a8b4a6b7194c4a46b21d74c455
Author: Matthias Bisping <matthias.bisping@axbit.com>
Date: Thu Feb 9 15:47:31 2023 +0100
Update dependencies
commit 970275b25708c05e4fbe78b52aa70d791d5ff17a
Author: Matthias Bisping <matthias.bisping@axbit.com>
Date: Thu Feb 9 15:35:37 2023 +0100
Refactoring
Make alpha channel check monadic to streamline error handling
commit e99e97e23fd8ce16f9a421d3e5442fccacf71ead
Author: Matthias Bisping <matthias.bisping@axbit.com>
Date: Tue Feb 7 14:32:29 2023 +0100
Refactoring
- Rename
- Refactor image extraction functions
commit 76b1b0ca2401495ec03ba2b6483091b52732eb81
Author: Matthias Bisping <matthias.bisping@axbit.com>
Date: Tue Feb 7 11:55:30 2023 +0100
Refactoring
commit cb1c461049d7c43ec340302f466447da9f95a499
Author: Matthias Bisping <matthias.bisping@axbit.com>
Date: Tue Feb 7 11:44:01 2023 +0100
Refactoring
commit 092069221a85ac7ac19bf838dcbc7ab1fde1e12b
Author: Matthias Bisping <matthias.bisping@axbit.com>
Date: Tue Feb 7 10:18:53 2023 +0100
Add to-do
commit 3cea4dad2d9703b8c79ddeb740b66a3b8255bb2a
Author: Matthias Bisping <matthias.bisping@axbit.com>
Date: Tue Feb 7 10:11:35 2023 +0100
Refactoring
- Rename
- Add typehints everywhere
commit 865e0819a14c420bc2edff454d41092c11c019a4
Author: Matthias Bisping <matthias.bisping@axbit.com>
Date: Mon Feb 6 19:38:57 2023 +0100
Add type explanation
commit 01d3d5d33f1ccb05aea1cec1d1577572b1a4deaa
Author: Matthias Bisping <matthias.bisping@axbit.com>
Date: Mon Feb 6 19:37:49 2023 +0100
Formatting
commit dffe1c18fc3a322a6b08890d4438844e8122faaf
Author: Matthias Bisping <matthias.bisping@axbit.com>
Date: Mon Feb 6 19:34:13 2023 +0100
[WIP] Either refactoring
Add alternative formulation for monadic chain
commit 066cf17add404a313520cd794c06e3264cf971c9
Author: Matthias Bisping <matthias.bisping@axbit.com>
Date: Mon Feb 6 18:40:30 2023 +0100
[WIP] Either refactoring
commit f53f0fea298cdab88deb090af328b34d37e0198e
Author: Matthias Bisping <matthias.bisping@axbit.com>
Date: Mon Feb 6 18:18:34 2023 +0100
[WIP] Either refactoring
Propagate error and metadata
commit 274a5f56d4fcb9c67fac5cf43e9412ec1ab5179e
Author: Matthias Bisping <matthias.bisping@axbit.com>
Date: Mon Feb 6 17:51:35 2023 +0100
[WIP] Either refactoring
Fix test assertion
commit 3235a857f6e418e50484cbfff152b0f63efb2f53
Author: Matthias Bisping <matthias.bisping@axbit.com>
Date: Mon Feb 6 16:57:31 2023 +0100
[WIP] Either-refactoring
Replace Maybe with Either to allow passing on error information or
metadata which otherwise get sucked up by Nothing.
commit 89989543d87490f8b20a0a76055605d34345e8f4
Author: Matthias Bisping <matthias.bisping@axbit.com>
Date: Mon Feb 6 16:12:40 2023 +0100
[WIP] Monadic refactoring
Integrate image validation step into monadic chain.
At the moment we lost the error information through this. Refactoring to
Either monad can bring it back.
commit 022bd4856a51aa085df5fe983fd77b99b53d594c
Author: Matthias Bisping <matthias.bisping@axbit.com>
Date: Mon Feb 6 15:16:41 2023 +0100
[WIP] Monadic refactoring
commit ca3898cb539607c8c3dd01c57e60211a5fea8a7d
Author: Matthias Bisping <matthias.bisping@axbit.com>
Date: Mon Feb 6 15:10:34 2023 +0100
[WIP] Monadic refactoring
commit d8f37bed5cbd6bdd2a0b52bae46fcdbb50f9dff2
Author: Matthias Bisping <matthias.bisping@axbit.com>
Date: Mon Feb 6 15:09:51 2023 +0100
[WIP] Monadic refactoring
commit 906fee0e5df051f38076aa1d2725e52a182ade13
Author: Matthias Bisping <matthias.bisping@axbit.com>
Date: Mon Feb 6 15:03:35 2023 +0100
[WIP] Monadic refactoring
... and 35 more commits
102 lines
3.2 KiB
Python
102 lines
3.2 KiB
Python
import json
|
|
import random
|
|
from operator import itemgetter
|
|
|
|
import fitz
|
|
import fpdf
|
|
import pytest
|
|
from PIL import Image
|
|
from funcy import first, rest
|
|
|
|
from image_prediction.exceptions import BadXref
|
|
from image_prediction.extraction import extract_images_from_pdf
|
|
from image_prediction.formatter.formatters.enum import EnumFormatter
|
|
from image_prediction.image_extractor.extractor import ImageMetadataPair
|
|
from image_prediction.image_extractor.extractors.parsable import (
|
|
extract_pages,
|
|
has_alpha_channel,
|
|
get_image_infos,
|
|
ParsablePDFImageExtractor,
|
|
extract_valid_metadata,
|
|
eith_extract_image,
|
|
extract_image,
|
|
)
|
|
from image_prediction.info import Info
|
|
from image_prediction.locations import TEST_DATA_DIR
|
|
from test.utils.comparison import metadata_equal, image_sets_equal
|
|
from test.utils.generation.pdf import add_image, pdf_stream, stream_pdf_bytes
|
|
|
|
|
|
@pytest.mark.parametrize("extractor_type", ["mock"])
|
|
@pytest.mark.parametrize("batch_size", [1, 2, 16])
|
|
def test_image_extractor_mock(image_extractor, images):
|
|
images_extracted, metadata = map(list, zip(*image_extractor(images)))
|
|
assert images_extracted == images
|
|
|
|
|
|
@pytest.mark.parametrize("extractor_type", ["parsable_pdf", "default"])
|
|
@pytest.mark.parametrize("input_size", [{"depth": 3, "width": 170, "height": 220}], indirect=["input_size"])
|
|
@pytest.mark.parametrize("alpha", [False, True])
|
|
def test_parsable_pdf_image_extractor(image_extractor, pdf, images, metadata, input_size, alpha):
|
|
images_extracted, metadata_extracted = map(list, extract_images_from_pdf(pdf, image_extractor))
|
|
if not alpha:
|
|
assert image_sets_equal(images_extracted, images)
|
|
assert metadata_equal(metadata_extracted, metadata)
|
|
|
|
|
|
@pytest.mark.parametrize("batch_size", [1, 2, 16])
|
|
def test_extract_pages(pdf):
|
|
doc = fitz.Document(stream=pdf)
|
|
|
|
max_index = max(0, doc.page_count - 1)
|
|
i = random.randint(0, max(0, max_index - 1))
|
|
j = random.randint(i + 1, max_index) if max_index > 0 else 0
|
|
|
|
page_range = range(i, j)
|
|
|
|
pages = list(extract_pages(doc, page_range))
|
|
assert all((isinstance(p, fitz.Page) for p in pages))
|
|
assert len(pages) == len(page_range)
|
|
|
|
|
|
@pytest.mark.parametrize("suffix", ["gif", "png", "jpeg"])
|
|
@pytest.mark.parametrize("mode", ["RGB", "RGBA"])
|
|
def test_has_alpha_channel(base_patch_metadata, suffix, mode):
|
|
|
|
mode = "RGB" if suffix == "jpeg" else mode
|
|
|
|
pdf = fpdf.FPDF(unit="pt")
|
|
|
|
image = Image.new(mode, itemgetter(Info.WIDTH, Info.HEIGHT)(base_patch_metadata), color=(10, 10, 10))
|
|
|
|
add_image(pdf, ImageMetadataPair(image, base_patch_metadata), suffix=suffix)
|
|
|
|
doc = fitz.Document(stream=pdf_stream(pdf))
|
|
|
|
page = first(doc)
|
|
|
|
xrefs = map(itemgetter("xref"), get_image_infos(page))
|
|
|
|
result = has_alpha_channel(doc, first(xrefs))
|
|
|
|
if mode == "RGBA":
|
|
assert result
|
|
if mode == "RGB":
|
|
assert not result
|
|
|
|
assert not list(rest(xrefs))
|
|
|
|
doc.close()
|
|
|
|
|
|
def test_bad_xref_handling(bad_xref_pdf, dvc_test_data):
|
|
|
|
doc = fitz.Document(stream=bad_xref_pdf)
|
|
metadata = extract_valid_metadata(doc, first(doc))
|
|
xref = first(metadata)[Info.XREF]
|
|
|
|
with pytest.raises(BadXref):
|
|
extract_image(doc, xref)
|
|
|
|
assert eith_extract_image(doc, xref).is_left()
|