From daba0bf8a6ba1caf4f641de7b3cb0fda7ebaf857 Mon Sep 17 00:00:00 2001 From: Corina Olariu Date: Wed, 4 Oct 2023 17:46:46 +0300 Subject: [PATCH] RED-7607 - Rotating pages leads to lost annotations (RM & DM) - remove finally clause --- .../graph/ExtractMarkedContentTest.java | 24 +++++-------------- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/layoutparser-service/layoutparser-service-server/src/test/java/com/knecon/fforesight/service/layoutparser/server/graph/ExtractMarkedContentTest.java b/layoutparser-service/layoutparser-service-server/src/test/java/com/knecon/fforesight/service/layoutparser/server/graph/ExtractMarkedContentTest.java index 176ed49..e8ba602 100644 --- a/layoutparser-service/layoutparser-service-server/src/test/java/com/knecon/fforesight/service/layoutparser/server/graph/ExtractMarkedContentTest.java +++ b/layoutparser-service/layoutparser-service-server/src/test/java/com/knecon/fforesight/service/layoutparser/server/graph/ExtractMarkedContentTest.java @@ -53,9 +53,7 @@ public class ExtractMarkedContentTest { @SneakyThrows public void testExtractTestWPhromma() throws IOException { System.out.printf("\n\n===\n%s\n===\n", "testWPhromma.pdf"); - PDDocument document = null; - try { - document = Loader.loadPDF(new ClassPathResource("files/bdr/Drucksache_19_9865.pdf").getFile()); + try (PDDocument document = Loader.loadPDF(new ClassPathResource("files/bdr/Drucksache_19_9865.pdf").getFile())) { Map> markedContents = new HashMap<>(); @@ -72,9 +70,7 @@ public class ExtractMarkedContentTest { PDStructureNode root = document.getDocumentCatalog().getStructureTreeRoot(); showStructure(root, markedContents); - } finally { - if (null != document ) - document.close(); + document.close(); } } @@ -94,9 +90,7 @@ public class ExtractMarkedContentTest { public void testExtractResMultipage() throws IOException { System.out.printf("\n\n===\n%s\n===\n", "res_multipage.pdf"); - PDDocument document = null; - try { - document = Loader.loadPDF(new ClassPathResource("files/bdr/Drucksache_19_9865.pdf").getFile()); + try(PDDocument document = Loader.loadPDF(new ClassPathResource("files/bdr/Drucksache_19_9865.pdf").getFile())) { Map> markedContents = new HashMap<>(); @@ -113,9 +107,7 @@ public class ExtractMarkedContentTest { PDStructureNode root = document.getDocumentCatalog().getStructureTreeRoot(); showStructure(root, markedContents); - } finally { - if (document != null) - document.close(); + document.close(); } } @@ -134,9 +126,7 @@ public class ExtractMarkedContentTest { @Test public void testExtractDailyReport() throws IOException { System.out.printf("\n\n===\n%s\n===\n", "Daily Report.pdf"); - PDDocument document = null; - try { - document = Loader.loadPDF(new ClassPathResource("files/bdr/Drucksache_19_9865.pdf").getFile()); + try (PDDocument document = Loader.loadPDF(new ClassPathResource("files/bdr/Drucksache_19_9865.pdf").getFile())) { Map> markedContents = new HashMap<>(); @@ -153,9 +143,7 @@ public class ExtractMarkedContentTest { PDStructureNode root = document.getDocumentCatalog().getStructureTreeRoot(); showStructure(root, markedContents); - } finally { - if (null != document) - document.close(); + document.close(); } }