Marmelator/pdf.js.mirror
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2026-07-29 02:17:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #21628 from calixteman/fix/pdf-editor-inherited-signature-flags

Browse Source 
Preserve inherited signature flags
This commit is contained in:
Tim van der Meij 2026-07-26 11:56:38 +02:00 committed by GitHub
commit 150fbba6e0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/editor/pdf_editor.js
View File

@ -1219,7 +1219,7 @@ class PDFEditor {
if (!isName(annotationDict.get("Subtype"), "Link")) {
if (isName(annotationDict.get("Subtype"), "Widget")) {
hasSignatureAnnotations ||= isName(
annotationDict.get("FT"),
getInheritableProperty({ dict: annotationDict, key: "FT" }),
"Sig"
);
const parentRef = annotationDict.getRaw("Parent") || null;

27
test/unit/api_spec.js
View File

@ -7758,6 +7758,33 @@ small scripts as well as for`);
await loadingTask.destroy();
});
it("preserves flags for inherited signature fields", async function () {
const pdfData = assemblePdf([
"1 0 obj\n<< /Type /Catalog /Pages 2 0 R " +
"/AcroForm 6 0 R >>\nendobj\n",
"2 0 obj\n<< /Type /Pages /Kids [3 0 R] /Count 1 >>\nendobj\n",
"3 0 obj\n<< /Type /Page /Parent 2 0 R " +
"/MediaBox [0 0 100 100] /Annots [4 0 R] >>\nendobj\n",
"4 0 obj\n<< /Type /Annot /Subtype /Widget /Rect [0 0 20 10] " +
"/Parent 5 0 R >>\nendobj\n",
"5 0 obj\n<< /FT /Sig /T (signature) /Kids [4 0 R] >>\nendobj\n",
"6 0 obj\n<< /Fields [5 0 R] /SigFlags 3 >>\nendobj\n",
]);
let loadingTask = getDocument({ data: pdfData });
let pdfDoc = await loadingTask.promise;
const data = await pdfDoc.extractPages([{ document: null }]);
expect(countMarker(data, "/SigFlags ")).toEqual(1);
await loadingTask.destroy();
loadingTask = getDocument({ data });
pdfDoc = await loadingTask.promise;
expect(Object.keys(await pdfDoc.getFieldObjects())).toEqual([
"signature",
]);
await loadingTask.destroy();
});
it("extract page 2 and check AcroForm Fields T entries", async function () {
let loadingTask = getDocument(
buildGetDocumentParams("form_two_pages.pdf")