Marmelator/pdf.js.mirror
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2026-06-22 16:05:56 +02:00
Code Issues Packages Projects Releases Wiki Activity

Move 'Save as...' menu to 'Export selected...'

Browse Source
This commit is contained in:
calixteman 2026-03-12 22:53:48 +01:00 committed by Calixte Denizet
parent a7083d08ff
commit 1d25607b9c
No known key found for this signature in database
GPG Key ID: 0C5442631EE0691F
5 changed files with 32 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
l10n/en-US/viewer.ftl
View File

@ -730,7 +730,7 @@ pdfjs-views-manager-pages-status-action-button-label = Manage
pdfjs-views-manager-pages-status-copy-button-label = Copy pdfjs-views-manager-pages-status-copy-button-label = Copy
pdfjs-views-manager-pages-status-cut-button-label = Cut pdfjs-views-manager-pages-status-cut-button-label = Cut
pdfjs-views-manager-pages-status-delete-button-label = Delete pdfjs-views-manager-pages-status-delete-button-label = Delete
pdfjs-views-manager-pages-status-save-as-button-label = Save as… pdfjs-views-manager-pages-status-export-selected-button-label = Export selected…
# Variables: # Variables:
# $count (Number) - the number of selected pages to be cut. # $count (Number) - the number of selected pages to be cut.

8
test/integration/reorganize_pages_spec.mjs
View File

@ -996,7 +996,7 @@ describe("Reorganize Pages View", () => {
"#viewsManagerStatusActionCopy:not(:disabled)" "#viewsManagerStatusActionCopy:not(:disabled)"
); );
await page.waitForSelector( await page.waitForSelector(
"#viewsManagerStatusActionSaveAs:not(:disabled)" "#viewsManagerStatusActionExport:not(:disabled)"
); );
await page.keyboard.press("Escape"); await page.keyboard.press("Escape");
@ -1739,7 +1739,7 @@ describe("Reorganize Pages View", () => {
`.thumbnail:has(${getThumbnailSelector(3)}) input` `.thumbnail:has(${getThumbnailSelector(3)}) input`
); );
const handleSaveAs = await createPromise(page, resolve => { const handleExport = await createPromise(page, resolve => {
window.PDFViewerApplication.eventBus.on( window.PDFViewerApplication.eventBus.on(
"saveextractedpages", "saveextractedpages",
({ data }) => { ({ data }) => {
@ -1752,8 +1752,8 @@ describe("Reorganize Pages View", () => {
}); });
await page.click("#viewsManagerStatusActionButton"); await page.click("#viewsManagerStatusActionButton");
await waitAndClick(page, "#viewsManagerStatusActionSaveAs"); await waitAndClick(page, "#viewsManagerStatusActionExport");
const pagesData = await awaitPromise(handleSaveAs); const pagesData = await awaitPromise(handleExport);
expect(pagesData) expect(pagesData)
.withContext(`In ${browserName}`) .withContext(`In ${browserName}`)
.toEqual([ .toEqual([

29
web/pdf_thumbnail_viewer.js
View File

@ -115,7 +115,7 @@ class PDFThumbnailViewer {
#pagesMapper = null; #pagesMapper = null;
#manageSaveAsButton = null; #manageExportButton = null;
#manageDeleteButton = null; #manageDeleteButton = null;
@ -197,7 +197,14 @@ class PDFThumbnailViewer {
// this.#addFileButton = addFileButton; // this.#addFileButton = addFileButton;
if (this.#enableSplitMerge && manageMenu) { if (this.#enableSplitMerge && manageMenu) {
const { button, menu, copy, cut, delete: del, saveAs } = manageMenu; const {
button,
menu,
copy,
cut,
delete: del,
exportSelected,
} = manageMenu;
this.eventBus.on( this.eventBus.on(
"pagesloaded", "pagesloaded",
() => { () => {
@ -206,9 +213,17 @@ class PDFThumbnailViewer {
{ once: true } { once: true }
); );
this._manageMenu = new Menu(menu, button, [copy, cut, del, saveAs]); this._manageMenu = new Menu(menu, button, [
this.#manageSaveAsButton = saveAs; copy,
saveAs.addEventListener("click", this.#saveExtractedPages.bind(this)); cut,
del,
exportSelected,
]);
this.#manageExportButton = exportSelected;
exportSelected.addEventListener(
"click",
this.#saveExtractedPages.bind(this)
);
this.#manageDeleteButton = del; this.#manageDeleteButton = del;
del.addEventListener("click", this.#deletePages.bind(this, "delete")); del.addEventListener("click", this.#deletePages.bind(this, "delete"));
this.#manageCopyButton = copy; this.#manageCopyButton = copy;
@ -890,13 +905,13 @@ class PDFThumbnailViewer {
#updateMenuEntries() { #updateMenuEntries() {
const size = this.#selectedPages?.size || 0; const size = this.#selectedPages?.size || 0;
this.#manageSaveAsButton.disabled = this.#manageCopyButton.disabled = !size; this.#manageExportButton.disabled = this.#manageCopyButton.disabled = !size;
this.#manageDeleteButton.disabled = this.#manageCutButton.disabled = this.#manageDeleteButton.disabled = this.#manageCutButton.disabled =
!this.#canDelete(); !this.#canDelete();
} }
#toggleMenuEntries(enable) { #toggleMenuEntries(enable) {
this.#manageSaveAsButton.disabled = this.#manageExportButton.disabled =
this.#manageDeleteButton.disabled = this.#manageDeleteButton.disabled =
this.#manageCopyButton.disabled = this.#manageCopyButton.disabled =
this.#manageCutButton.disabled = this.#manageCutButton.disabled =

4
web/viewer.html
View File

@ -233,8 +233,8 @@ See https://github.com/adobe-type-tools/cmap-resources
</button> </button>
</li> </li>
<li> <li>
<button id="viewsManagerStatusActionSaveAs" class="noIcon" role="menuitem" type="button" tabindex="-1" disabled> <button id="viewsManagerStatusActionExport" class="noIcon" role="menuitem" type="button" tabindex="-1" disabled>
<span data-l10n-id="pdfjs-views-manager-pages-status-save-as-button-label"></span> <span data-l10n-id="pdfjs-views-manager-pages-status-export-selected-button-label"></span>
</button> </button>
</li> </li>
</menu> </menu>

4
web/viewer.js
View File

@ -165,7 +165,9 @@ function getViewerConfiguration() {
copy: document.getElementById("viewsManagerStatusActionCopy"), copy: document.getElementById("viewsManagerStatusActionCopy"),
cut: document.getElementById("viewsManagerStatusActionCut"), cut: document.getElementById("viewsManagerStatusActionCut"),
delete: document.getElementById("viewsManagerStatusActionDelete"), delete: document.getElementById("viewsManagerStatusActionDelete"),
saveAs: document.getElementById("viewsManagerStatusActionSaveAs"), exportSelected: document.getElementById(
"viewsManagerStatusActionExport"
),
}, },
}, },
findBar: { findBar: {