From 1f69cf964c5f3cba1ff9387b1fd7c3052d4f5c64 Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Sun, 8 Mar 2026 09:47:11 +0100
Subject: [PATCH] Ensure that `percent === NaN` is consistently reported by the
 `onProgress` callback

With these changes `0`, `NaN`, `null`, and `undefined` in the `total`-property all result in `percent === NaN` being reported by the callback, since previously e.g. `0` would result in `percent === 100` being reported unconditionally which doesn't make a lot of sense.

Also, remove the "indeterminate" loadingBar (in the viewer) if the `PDFDocumentLoadingTask` fails since there won't be any more data arriving and displaying the animation thus seems wrong.
---
 src/display/api.js | 4 +++-
 web/app.js         | 4 ++++
 web/firefoxcom.js  | 8 +++-----
 3 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/display/api.js b/src/display/api.js
index 004970e68..7ac3bc8f8 100644
--- a/src/display/api.js
+++ b/src/display/api.js
@@ -2524,7 +2524,9 @@ class WorkerTransport {
     this.loadingTask.onProgress?.({
       loaded,
       total,
-      percent: MathClamp(Math.round((loaded / total) * 100), 0, 100),
+      percent: total
+        ? MathClamp(Math.round((loaded / total) * 100), 0, 100)
+        : NaN,
     });
   }
 
diff --git a/web/app.js b/web/app.js
index 89be5b082..02697b859 100644
--- a/web/app.js
+++ b/web/app.js
@@ -1255,6 +1255,10 @@ const PDFViewerApplication = {
         if (loadingTask !== this.pdfLoadingTask) {
           return undefined; // Ignore errors for previously opened PDF files.
         }
+        if (this.loadingBar) {
+          // Avoid the "indeterminate" loadingBar being displayed on error.
+          this.loadingBar.percent ||= 0;
+        }
 
         let key = "pdfjs-loading-error";
         if (reason instanceof InvalidPDFException) {
diff --git a/web/firefoxcom.js b/web/firefoxcom.js
index bc90f67df..b12645574 100644
--- a/web/firefoxcom.js
+++ b/web/firefoxcom.js
@@ -577,11 +577,9 @@ class ExternalServices extends BaseExternalServices {
           pdfDataRangeTransport?.onDataProgressiveDone();
           break;
         case "progress":
-          const percent = MathClamp(
-            Math.round((args.loaded / args.total) * 100),
-            0,
-            100
-          );
+          const percent = args.total
+            ? MathClamp(Math.round((args.loaded / args.total) * 100), 0, 100)
+            : NaN;
 
           viewerApp.progress(percent);
           break;