Marmelator/pdf.js.mirror
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2026-04-09 14:54:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix intermittent failure in the "must check that the comment sidebar is resizable with the keyboard" comment integration test

Browse Source 
In PR #20887 the issue got fixed partly, but two issues remained that
unintendedly left room for intermittent failres:

- in the "Ctrl+ArrowLeft/Right" loop the `waitForBrowserTrip` call was
  placed _before_ the actual keypresses, which means that for the final
  iteration of the loop the last key presses were not properly awaited;

- in the "ArrowLeft/ArrowRight" loop the `waitForBrowserTrip` call was
  absent, which means that we didn't wait for key presses at all.

This commit fixes the issues by consistently waiting to a browser trip
_after_ each key press to make sure the sidebar got a chance to render.
This commit is contained in:
Tim van der Meij 2026-04-04 19:07:25 +02:00
parent e10f11bd3a
commit 24e5377240
No known key found for this signature in database
GPG Key ID: 8C3FD2925A5F2762
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/integration/comment_spec.mjs
View File

@ -571,10 +571,10 @@ describe("Comment", () => {
const rect = await getRect(page, sidebarSelector);
const arrowKey = extraWidth > 0 ? "ArrowLeft" : "ArrowRight";
for (let i = 0; i < Math.abs(extraWidth); i++) {
await waitForBrowserTrip(page);
await kbModifierDown(page);
await page.keyboard.press(arrowKey);
await kbModifierUp(page);
await waitForBrowserTrip(page);
}
const rectAfter = await getRect(page, sidebarSelector);
@ -592,6 +592,7 @@ describe("Comment", () => {
const arrowKey = extraWidth > 0 ? "ArrowLeft" : "ArrowRight";
for (let i = 0; i < Math.abs(extraWidth); i++) {
await page.keyboard.press(arrowKey);
await waitForBrowserTrip(page);
}
const rectAfter = await getRect(page, sidebarSelector);