Marmelator/pdf.js.mirror
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2026-06-30 12:15:49 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #21513 from calixteman/bug2051221

Browse Source 
Remove the BOM from html files (bug 2051221)
This commit is contained in:
calixteman 2026-06-29 22:21:29 +02:00 committed by GitHub
commit 25eae30e4e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 68 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

67
gulpfile.mjs
View File

@ -2396,6 +2396,71 @@ gulp.task("lint-chmod", function (done) {
done();
});
gulp.task("lint-bom", async function () {
console.log("\n### Checking for UTF-8 byte order marks");
// Cover untracked-but-not-ignored files too, so a BOM in a freshly created
// file is caught before `git add`.
const files = execSync("git ls-files -coz --exclude-standard", {
encoding: "utf8",
maxBuffer: 1 << 28,
})
.split("\0")
.filter(Boolean);
// Only the first three bytes matter: a leading EF BB BF is a UTF-8 BOM.
async function hasBOM(file) {
let handle;
try {
handle = await fs.promises.open(file, "r");
} catch {
return false; // Directory, broken symlink, removed file, etc.
}
try {
const { bytesRead, buffer } = await handle.read(Buffer.alloc(3), 0, 3, 0);
return (
bytesRead === 3 &&
buffer[0] === 0xef &&
buffer[1] === 0xbb &&
buffer[2] === 0xbf
);
} finally {
await handle.close();
}
}
// Don't exhaust file descriptors.
const offenders = [];
for (let i = 0; i < files.length; i += 256) {
const chunk = files.slice(i, i + 256);
const flags = await Promise.all(chunk.map(hasBOM));
chunk.forEach((file, j) => flags[j] && offenders.push(file));
}
offenders.sort();
if (offenders.length === 0) {
console.log("files checked, no errors found");
return;
}
if (!process.argv.includes("--fix")) {
for (const file of offenders) {
console.log(` Unexpected byte order mark: ${file}`);
}
throw new Error("BOM check failed (run `gulp lint-bom --fix` to clear).");
}
// Strip the BOM on disk and let the user stage the change.
await Promise.all(
offenders.map(async file => {
const content = await fs.promises.readFile(file);
await fs.promises.writeFile(file, content.subarray(3));
console.log(` removed byte order mark: ${file}`);
})
);
console.log(`done: ${offenders.length} file(s) updated`);
});
gulp.task("lint", function (done) {
console.log("\n### Linting JS/CSS/JSON/SVG/HTML files");
@ -2460,7 +2525,7 @@ gulp.task("lint", function (done) {
return;
}
gulp.series("lint-licenses", "lint-chmod")(done);
gulp.series("lint-licenses", "lint-chmod", "lint-bom")(done);
});
});

2
web/viewer-geckoview.html
View File

@ -1,4 +1,4 @@
<!doctype html>
<!doctype html>
<!--
Copyright 2012 Mozilla Foundation

2
web/viewer.html
View File

@ -1,4 +1,4 @@
<!doctype html>
<!doctype html>
<!--
Copyright 2012 Mozilla Foundation