Marmelator/pdf.js.mirror
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2026-06-23 00:15:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

Collect coverage data from all workers when closing integration-tests

Browse Source 
The "Merge PDF" integration-tests will (indirectly) invoke `PDFViewerApplication.open` as part of loading the new PDF document, which will end up creating a new `PDFWorker` instance.
Currently worker coverage is only collected at the end of each integration-test, which means that in these cases we miss the coverage data from any "previous" workers.
This commit is contained in:
Jonas Jenwald 2026-06-13 22:54:33 +02:00
parent feec28583d
commit 2dc73ad2a7
2 changed files with 19 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
test/integration/test_utils.mjs
View File

@ -151,19 +151,6 @@ function closePages(pages) {
async function closeSinglePage(page) { async function closeSinglePage(page) {
const coverage = await page.evaluate(async () => { const coverage = await page.evaluate(async () => {
// Collect coverage data from the worker before the document is closed.
let workerCoverage = null;
const handler =
window.PDFViewerApplication.pdfDocument?._transport?.messageHandler;
if (handler) {
try {
workerCoverage = await handler.sendWithPromise(
"GetWorkerCoverage",
null
);
} catch {}
}
// Close the viewer gracefully, and clear local storage to avoid state // Close the viewer gracefully, and clear local storage to avoid state
// leaking from one test to another. // leaking from one test to another.
await window.PDFViewerApplication.testingClose(); await window.PDFViewerApplication.testingClose();
@ -175,16 +162,14 @@ async function closeSinglePage(page) {
// logic kicks in (see https://github.com/puppeteer/puppeteer/issues/2427). // logic kicks in (see https://github.com/puppeteer/puppeteer/issues/2427).
return { return {
page: window.__coverage__ ? JSON.stringify(window.__coverage__) : null, page: window.__coverage__ ? JSON.stringify(window.__coverage__) : null,
worker: workerCoverage ? JSON.stringify(workerCoverage) : null, workers: window.__worker_coverage__?.map(c => JSON.stringify(c)) ?? null,
}; };
}); });
if (coverage.page) { if (coverage.page) {
mergeCoverageIntoGlobal(JSON.parse(coverage.page)); mergeCoverageIntoGlobal(JSON.parse(coverage.page));
} }
if (coverage.worker) { coverage.workers?.map(c => mergeCoverageIntoGlobal(JSON.parse(c)));
mergeCoverageIntoGlobal(JSON.parse(coverage.worker));
}
await page.close({ runBeforeUnload: false }); await page.close({ runBeforeUnload: false });
} }

17
web/app.js
View File

@ -1165,6 +1165,23 @@ const PDFViewerApplication = {
// Ignoring errors, to ensure that document closing won't break. // Ignoring errors, to ensure that document closing won't break.
} }
} }
if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("COVERAGE")) {
// Collect coverage data from the worker before the document is closed.
//
// Note that `PDFViewerApplication.open` may be invoked multiple times
// during an integration-test (see e.g. the "Merge PDF" tests).
const handler = this.pdfDocument?._transport?.messageHandler;
if (handler) {
try {
const workerCoverage = await handler.sendWithPromise(
"GetWorkerCoverage",
null
);
(window.__worker_coverage__ ??= []).push(workerCoverage);
} catch {}
}
}
const promises = []; const promises = [];
promises.push(this.pdfLoadingTask.destroy()); promises.push(this.pdfLoadingTask.destroy());