From a1f1a56080b14197d49d8af44d1fd2dbec0c66f7 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Thu, 2 Jul 2026 18:40:34 +0200 Subject: [PATCH 1/2] [GeckoView] Add `web-digital_signature_properties_manager` import map (PR 21247 follow-up) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently the GeckoView development viewer, i.e. http://localhost:8888/web/viewer-geckoview.html, is completely broken with the following error: ``` Uncaught TypeError: The specifier “web-digital_signature_properties_manager” was a bare specifier, but was not remapped to anything. Relative module specifiers must start with “./”, “../” or “/”. app.js:97:44 ``` --- web/viewer-geckoview.html | 1 + 1 file changed, 1 insertion(+) diff --git a/web/viewer-geckoview.html b/web/viewer-geckoview.html index b7bb83c0e..9461b9421 100644 --- a/web/viewer-geckoview.html +++ b/web/viewer-geckoview.html @@ -88,6 +88,7 @@ See https://github.com/adobe-type-tools/cmap-resources "web-print_service": "./pdf_print_service.js", "web-secondary_toolbar": "./stubs-geckoview.js", "web-signature_manager": "./stubs-geckoview.js", + "web-digital_signature_properties_manager": "./digital_signature_properties_manager.js", "web-toolbar": "./toolbar-geckoview.js", "web-views_manager": "./stubs-geckoview.js" } From 12691fdf5028108dad3ece77e4476f221ef786c6 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Thu, 2 Jul 2026 18:46:41 +0200 Subject: [PATCH 2/2] Remove unnecessary class-field resetting in `SignaturePropertiesManager.prototype.setDocument` (PR 21247 follow-up) This corresponds to the initial values of these fields, and they were *already* reset when a (previous) PDF document was closed. --- web/digital_signature_properties_manager.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/web/digital_signature_properties_manager.js b/web/digital_signature_properties_manager.js index 17f285175..3f441b94b 100644 --- a/web/digital_signature_properties_manager.js +++ b/web/digital_signature_properties_manager.js @@ -263,9 +263,6 @@ class SignaturePropertiesManager { if (!pdfDocument) { return; } - this.#signatures = []; - this.#results.clear(); - this.#pendingVerify.clear(); this.#isLoading = true; this.#render(); @@ -274,7 +271,6 @@ class SignaturePropertiesManager { signatures = await pdfDocument.getSignatures(); } catch (ex) { console.warn("getSignatures failed:", ex); - signatures = []; } if (pdfDocument !== this.#pdfDocument) { return;