From 45c7805daf3bc2286559254e4438d3d06111b7a9 Mon Sep 17 00:00:00 2001 From: calixteman Date: Sun, 8 Feb 2026 22:12:31 +0100 Subject: [PATCH] Fix types to make "gulp typestest" succeeding --- .github/workflows/types_tests.yml | 2 +- src/display/annotation_layer.js | 4 ++++ src/display/editor/annotation_editor_layer.js | 3 ++- src/display/xfa_layer.js | 2 ++ web/annotation_layer_builder.js | 3 +++ web/pdf_find_controller.js | 1 + web/pdf_history.js | 1 + web/pdf_page_view.js | 1 + web/pdf_rendering_queue.js | 1 + web/pdf_thumbnail_viewer.js | 1 + web/pdf_viewer.js | 4 ++++ web/renderable_view.js | 6 +++--- web/xfa_layer_builder.js | 1 + 13 files changed, 25 insertions(+), 5 deletions(-) diff --git a/.github/workflows/types_tests.yml b/.github/workflows/types_tests.yml index 55674c350..15bb3d25d 100644 --- a/.github/workflows/types_tests.yml +++ b/.github/workflows/types_tests.yml @@ -28,4 +28,4 @@ jobs: run: npm ci - name: Run types tests - run: npx gulp types + run: npx gulp typestest diff --git a/src/display/annotation_layer.js b/src/display/annotation_layer.js index d289fbd18..e486221c1 100644 --- a/src/display/annotation_layer.js +++ b/src/display/annotation_layer.js @@ -23,6 +23,10 @@ /** @typedef {import("../../web/struct_tree_layer_builder.js").StructTreeLayerBuilder} StructTreeLayerBuilder */ // eslint-disable-next-line max-len /** @typedef {import("../../web/comment_manager.js").CommentManager} CommentManager */ +// eslint-disable-next-line max-len +/** @typedef {import("../../web/pdf_link_service.js").PDFLinkService} PDFLinkService */ +// eslint-disable-next-line max-len +/** @typedef {import("../../web/base_download_manager.js").BaseDownloadManager} BaseDownloadManager */ import { AnnotationBorderStyleType, diff --git a/src/display/editor/annotation_editor_layer.js b/src/display/editor/annotation_editor_layer.js index 781f2f620..9d27cfca8 100644 --- a/src/display/editor/annotation_editor_layer.js +++ b/src/display/editor/annotation_editor_layer.js @@ -22,7 +22,8 @@ /** @typedef {import("../annotation_layer.js").AnnotationLayer} AnnotationLayer */ /** @typedef {import("../draw_layer.js").DrawLayer} DrawLayer */ // eslint-disable-next-line max-len -/** @typedef {import("../src/display/struct_tree_layer_builder.js").StructTreeLayerBuilder} StructTreeLayerBuilder */ +/** @typedef {import("../../../web/struct_tree_layer_builder.js").StructTreeLayerBuilder} StructTreeLayerBuilder */ +/** @typedef {import("../../../web/l10n.js").L10n} L10n */ import { AnnotationEditorPrefix, diff --git a/src/display/xfa_layer.js b/src/display/xfa_layer.js index 6ddf9b58e..2cd8452c3 100644 --- a/src/display/xfa_layer.js +++ b/src/display/xfa_layer.js @@ -16,6 +16,8 @@ // eslint-disable-next-line max-len /** @typedef {import("./annotation_storage").AnnotationStorage} AnnotationStorage */ /** @typedef {import("./display_utils").PageViewport} PageViewport */ +// eslint-disable-next-line max-len +/** @typedef {import("../../web/pdf_link_service.js").PDFLinkService} PDFLinkService */ import { XfaText } from "./xfa_text.js"; diff --git a/web/annotation_layer_builder.js b/web/annotation_layer_builder.js index 974db622e..5d4a443c4 100644 --- a/web/annotation_layer_builder.js +++ b/web/annotation_layer_builder.js @@ -25,6 +25,9 @@ // eslint-disable-next-line max-len /** @typedef {import("../src/display/editor/tools.js").AnnotationEditorUIManager} AnnotationEditorUIManager */ /** @typedef {import("./comment_manager.js").CommentManager} CommentManager */ +/** @typedef {import("./pdf_link_service.js").PDFLinkService} PDFLinkService */ +// eslint-disable-next-line max-len +/** @typedef {import("./base_download_manager.js").BaseDownloadManager} BaseDownloadManager */ import { AnnotationLayer, diff --git a/web/pdf_find_controller.js b/web/pdf_find_controller.js index 03dada3d6..8c5fae22c 100644 --- a/web/pdf_find_controller.js +++ b/web/pdf_find_controller.js @@ -15,6 +15,7 @@ /** @typedef {import("../src/display/api").PDFDocumentProxy} PDFDocumentProxy */ /** @typedef {import("./event_utils").EventBus} EventBus */ +/** @typedef {import("./pdf_link_service.js").PDFLinkService} PDFLinkService */ import { binarySearchFirstItem, scrollIntoView } from "./ui_utils.js"; import { getCharacterType, getNormalizeWithNFKC } from "./pdf_find_utils.js"; diff --git a/web/pdf_history.js b/web/pdf_history.js index f0f7964db..c4eaab841 100644 --- a/web/pdf_history.js +++ b/web/pdf_history.js @@ -14,6 +14,7 @@ */ /** @typedef {import("./event_utils").EventBus} EventBus */ +/** @typedef {import("./pdf_link_service.js").PDFLinkService} PDFLinkService */ import { isValidRotation, parseQueryString } from "./ui_utils.js"; import { updateUrlHash } from "pdfjs-lib"; diff --git a/web/pdf_page_view.js b/web/pdf_page_view.js index 37e888ffb..a0c06a96e 100644 --- a/web/pdf_page_view.js +++ b/web/pdf_page_view.js @@ -21,6 +21,7 @@ // eslint-disable-next-line max-len /** @typedef {import("./pdf_rendering_queue").PDFRenderingQueue} PDFRenderingQueue */ /** @typedef {import("./comment_manager.js").CommentManager} CommentManager */ +/** @typedef {import("./l10n.js").L10n} L10n */ import { AbortException, diff --git a/web/pdf_rendering_queue.js b/web/pdf_rendering_queue.js index 0b2a5975a..9b1fec47d 100644 --- a/web/pdf_rendering_queue.js +++ b/web/pdf_rendering_queue.js @@ -16,6 +16,7 @@ /** @typedef {import("./pdf_viewer").PDFViewer} PDFViewer */ // eslint-disable-next-line max-len /** @typedef {import("./pdf_thumbnail_viewer").PDFThumbnailViewer} PDFThumbnailViewer */ +/** @typedef {import("./renderable_view").RenderableView} RenderableView */ import { RenderingCancelledException } from "pdfjs-lib"; import { RenderingStates } from "./renderable_view.js"; diff --git a/web/pdf_thumbnail_viewer.js b/web/pdf_thumbnail_viewer.js index 23263ac70..66a07e097 100644 --- a/web/pdf_thumbnail_viewer.js +++ b/web/pdf_thumbnail_viewer.js @@ -18,6 +18,7 @@ /** @typedef {import("./event_utils").EventBus} EventBus */ // eslint-disable-next-line max-len /** @typedef {import("./pdf_rendering_queue").PDFRenderingQueue} PDFRenderingQueue */ +/** @typedef {import("./pdf_link_service.js").PDFLinkService} PDFLinkService */ import { binarySearchFirstItem, diff --git a/web/pdf_viewer.js b/web/pdf_viewer.js index 5937ee210..e938136ab 100644 --- a/web/pdf_viewer.js +++ b/web/pdf_viewer.js @@ -24,6 +24,10 @@ /** @typedef {import("./pdf_find_controller").PDFFindController} PDFFindController */ // eslint-disable-next-line max-len /** @typedef {import("./pdf_scripting_manager").PDFScriptingManager} PDFScriptingManager */ +/** @typedef {import("./pdf_link_service.js").PDFLinkService} PDFLinkService */ +// eslint-disable-next-line max-len +/** @typedef {import("./base_download_manager.js").BaseDownloadManager} BaseDownloadManager */ +/** @typedef {import("./l10n.js").L10n} L10n */ import { AnnotationEditorType, diff --git a/web/renderable_view.js b/web/renderable_view.js index 086d8f03a..6ffe2da63 100644 --- a/web/renderable_view.js +++ b/web/renderable_view.js @@ -28,7 +28,7 @@ class RenderableView { renderingId = ""; /** - * @type {RenderTask | null} + * @type {import("../src/display/api").RenderTask | null} */ renderTask = null; @@ -47,14 +47,14 @@ class RenderableView { } /** - * @type {RenderingStates} + * @type {number} */ get renderingState() { throw new Error("Abstract getter `renderingState` accessed"); } /** - * @param {RenderingStates} + * @param {number} state */ set renderingState(state) { throw new Error("Abstract setter `renderingState` accessed"); diff --git a/web/xfa_layer_builder.js b/web/xfa_layer_builder.js index 9f7a92d87..88e74fc20 100644 --- a/web/xfa_layer_builder.js +++ b/web/xfa_layer_builder.js @@ -18,6 +18,7 @@ /** @typedef {import("../src/display/annotation_storage").AnnotationStorage} AnnotationStorage */ // eslint-disable-next-line max-len /** @typedef {import("../src/display/display_utils").PageViewport} PageViewport */ +/** @typedef {import("./pdf_link_service.js").PDFLinkService} PDFLinkService */ import { XfaLayer } from "pdfjs-lib";