Merge pull request #21605 from calixteman/followup_21598

Address follow-up review comments in coverage_search.mjs
This commit is contained in:
calixteman 2026-07-19 23:19:55 +02:00 committed by GitHub
commit 547236bcd5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -108,19 +108,19 @@ async function refreshIndex() {
process.exit(1); process.exit(1);
}; };
const headers = {}; const headers = new Headers();
if (hasCached && fs.existsSync(etagPath)) { if (hasCached && fs.existsSync(etagPath)) {
const etag = fs.readFileSync(etagPath, "utf8").trim(); const etag = fs.readFileSync(etagPath, "utf8").trim();
// Only forward a syntactically valid HTTP ETag (RFC 7232), so the cached // Only forward a syntactically valid HTTP ETag (RFC 7232), so the cached
// file's contents can't be used to inject arbitrary data into the request. // file's contents can't be used to inject arbitrary data into the request.
if (/^(?:W\/)?"[\x21\x23-\x7e]*"$/.test(etag)) { if (/^(?:W\/)?"[\x21\x23-\x7e]*"$/.test(etag)) {
headers["If-None-Match"] = etag; headers.set("If-None-Match", etag);
} }
} }
let response; let response;
try { try {
console.error(`Fetching per-test index from ${PER_TEST_INDEX_URL} ...`); console.log(`Fetching per-test index from ${PER_TEST_INDEX_URL} ...`);
response = await fetch(PER_TEST_INDEX_URL, { headers }); response = await fetch(PER_TEST_INDEX_URL, { headers });
} catch (error) { } catch (error) {
fallbackOrFail(error.message); fallbackOrFail(error.message);
@ -128,7 +128,7 @@ async function refreshIndex() {
} }
if (response.status === 304) { if (response.status === 304) {
console.error("Per-test index is up to date."); console.log("Per-test index is up to date.");
return; return;
} }
if (!response.ok) { if (!response.ok) {
@ -174,7 +174,7 @@ async function refreshIndex() {
fallbackOrFail(error.message); fallbackOrFail(error.message);
return; return;
} }
console.error(`Per-test index updated (${serialized.length} bytes).`); console.log(`Per-test index updated (${serialized.length} bytes).`);
} }
await refreshIndex(); await refreshIndex();