Marmelator/pdf.js.mirror
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2026-06-05 17:51:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove the #externalHide field from the AnnotationLayerBuilder class

Browse Source 
Prior to PR 20321 the annotationLayer was hidden when there was no regular annotations on the page, which meant that if there were any inferred links (from the textLayer) the annotationLayer needed to be made visible but in such a way that it wouldn't override an explicit `hide`-call from the `PDFPageView` class.

With the changes in the aforementioned PR the annotationLayer is now always "visible", and this code can thus be simplified a little bit.
This commit is contained in:
Jonas Jenwald 2026-06-03 13:46:40 +02:00
parent 19046a6949
commit 5907d87774
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
web/annotation_layer_builder.js
View File

@ -72,8 +72,6 @@ class AnnotationLayerBuilder {
#commentManager = null;
#externalHide = false;
#onAppend = null;
#eventAC = null;
@ -226,8 +224,7 @@ class AnnotationLayerBuilder {
this.#eventAC = null;
}
hide(internal = false) {
this.#externalHide = !internal;
hide() {
if (!this.div) {
return;
}
@ -263,10 +260,6 @@ class AnnotationLayerBuilder {
}
await this.annotationLayer.addLinkAnnotations(newLinks);
// Don't show the annotation layer if it was explicitly hidden previously.
if (!this.#externalHide) {
this.div.hidden = false;
}
}
#updatePresentationModeState(state) {