Marmelator/pdf.js.mirror
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2026-06-03 08:41:01 +02:00
Code Issues Packages Projects Releases Wiki Activity

Disable hardware acceleration for Chrome tests

Browse Source 
This commit fixes the rendering issue that makes the "must update an
existing annotation" ink editor integration test permafail locally in
Chrome. Note that we already do this for Firefox tests, so this also
improves consistency between the two browsers.

Moreover, improve how we define Chrome options to (similar to their
Firefox counterparts) provide them in a single array, and document the
reasoning for why these options are being set more explicitly.

Fixes #21272.
This commit is contained in:
Tim van der Meij 2026-05-19 20:16:32 +02:00
parent f500cffd2e
commit 60591388a8
No known key found for this signature in database
GPG Key ID: 8C3FD2925A5F2762
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
test/test.mjs
View File

@ -994,10 +994,18 @@ async function startBrowser({
// value gives Chrome a more similar execution speed as Firefox.
options.slowMo = 3;
// avoid crash
options.args = ["--no-sandbox", "--disable-setuid-sandbox"];
// silent printing in a pdf
options.args.push("--kiosk-printing");
options.args = [
// Avoid crashing because no sandbox is shipped by default and we only run
// our own trusted content in the scope of the tests (for more information
// see https://pptr.dev/troubleshooting#setting-up-chrome-linux-sandbox).
"--no-sandbox",
"--disable-setuid-sandbox",
// Print PDFs silently (without print preview or user interaction).
"--kiosk-printing",
// Disable hardware acceleration (fixes rendering issues, see #15168 and
// #21272, and environments like GitHub Actions don't expose GPUs anyway).
"--disable-gpu",
];
}
if (browserName === "firefox") {
@ -1016,12 +1024,13 @@ async function startBrowser({
// Save file in output
"browser.download.folderList": 2,
"browser.download.dir": tempDir,
// Print silently in a pdf
// Print PDFs silently (without print preview or user interaction).
"print.always_print_silent": true,
print_printer: "PDF",
"print.printer_PDF.print_to_file": true,
"print.printer_PDF.print_to_filename": printFile,
// Disable gpu acceleration
// Disable hardware acceleration (fixes rendering issues, see #15168 and
// #21272, and environments like GitHub Actions don't expose GPUs anyway).
"gfx.canvas.accelerated": false,
// It's helpful to see where the caret is.
"accessibility.browsewithcaret": true,