Marmelator/pdf.js.mirror
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2026-06-07 18:51:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

Get the zIndex correctly in PopupElement.prototype.renderCommentButton

Browse Source 
In practice this probably hasn't caused any bugs, however given that `DOMElement.style.zIndex` returns a string the existing code is subtly wrong.
This is also consistent with pre-existing `zIndex` code in the `PopupElement` class, see the `#show` and `#hide` methods.
This commit is contained in:
Jonas Jenwald 2026-04-26 14:33:47 +02:00
parent 5c11bf15b0
commit 72011c5088
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/display/annotation_layer.js
View File

@ -2596,7 +2596,7 @@ class PopupElement {
const button = (this.#commentButton = document.createElement("button"));
button.className = "annotationCommentButton";
const parentContainer = this.#firstElement.container;
button.style.zIndex = parentContainer.style.zIndex + 1;
button.style.zIndex = parseInt(parentContainer.style.zIndex, 10) + 1;
button.tabIndex = 0;
button.ariaHasPopup = "dialog";
button.ariaControls = "commentPopup";
@ -3778,6 +3778,8 @@ class AnnotationLayer {
#hasAriaAttributesFromStructTree = false;
zIndex = 0;
constructor({
div,
accessibilityManager,
@ -3798,7 +3800,6 @@ class AnnotationLayer {
this.#annotationStorage = annotationStorage || new AnnotationStorage();
this.page = page;
this.viewport = viewport;
this.zIndex = 0;
this._annotationEditorUIManager = annotationEditorUIManager;
this._commentManager = commentManager || null;