From e3a7c0779d034901fbe71894504fdc050cd32612 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Fri, 27 Feb 2026 15:19:43 +0100 Subject: [PATCH] Fix the broken regular expression in the `decode` helper in the `getPdfFilenameFromUrl` function (issue 20664) This will ignore filenames that become effectively empty, i.e. ones that are only ".pdf" and nothing more. *Please note:* While this passes all existing unit-tests, I don't know if this is necessarily the "correct" solution here. --- src/display/display_utils.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/display/display_utils.js b/src/display/display_utils.js index a1f6e4469..0950b806e 100644 --- a/src/display/display_utils.js +++ b/src/display/display_utils.js @@ -377,10 +377,9 @@ function getPdfFilenameFromUrl(url, defaultFilename = "document.pdf") { let decoded = decodeURIComponent(name); if (decoded.includes("/")) { decoded = stripPath(decoded); - if (decoded.test(/^\.pdf$/i)) { - return decoded; + if (/^\.pdf$/i.test(decoded)) { + return name; } - return name; } return decoded; } catch {