Merge pull request #19117 from Snuffleupagus/bot-forceNoChrome

Disable the browser-tests in Google Chrome on the bots
This commit is contained in:
Jonas Jenwald 2024-12-01 18:28:03 +01:00 committed by GitHub
commit 867aaf01fa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 8 additions and 21 deletions

View File

@ -686,12 +686,9 @@ function runTests(testsName, { bot = false, xfaOnly = false } = {}) {
if (!bot) { if (!bot) {
args.push("--reftest"); args.push("--reftest");
} else { } else {
const os = process.env.OS; // The browser-tests are too slow in Google Chrome on the bots,
if (/windows/i.test(os)) { // causing a timeout, hence disabling them for now.
// The browser-tests are too slow in Google Chrome on the Windows forceNoChrome = true;
// bot, causing a timeout, hence disabling them for now.
forceNoChrome = true;
}
} }
if (xfaOnly) { if (xfaOnly) {
args.push("--xfaOnly"); args.push("--xfaOnly");
@ -770,12 +767,10 @@ function makeRef(done, bot) {
let forceNoChrome = false; let forceNoChrome = false;
const args = ["test.mjs", "--masterMode"]; const args = ["test.mjs", "--masterMode"];
if (bot) { if (bot) {
const os = process.env.OS; // The browser-tests are too slow in Google Chrome on the bots,
if (/windows/i.test(os)) { // causing a timeout, hence disabling them for now.
// The browser-tests are too slow in Google Chrome on the Windows forceNoChrome = true;
// bot, causing a timeout, hence disabling them for now.
forceNoChrome = true;
}
args.push("--noPrompts", "--strictVerify"); args.push("--noPrompts", "--strictVerify");
} }
if (process.argv.includes("--noChrome") || forceNoChrome) { if (process.argv.includes("--noChrome") || forceNoChrome) {

View File

@ -609,13 +609,6 @@ class Driver {
return; return;
} }
if (task.noChrome && window?.chrome) {
this._log(`Skipping file "${task.file}" (because on Chrome)\n`);
this.currentTask++;
this._nextTask();
return;
}
this._log('Loading file "' + task.file + '"\n'); this._log('Loading file "' + task.file + '"\n');
try { try {

View File

@ -10829,8 +10829,7 @@
"rounds": 1, "rounds": 1,
"type": "eq", "type": "eq",
"link": true, "link": true,
"talos": false, "talos": false
"noChrome": true
}, },
{ {
"id": "issue18956", "id": "issue18956",