Use the waitForTextToBe helper function in the editor alert bar integration tests

This reduces the amount of code needed for the checks, and thereby makes
the intent of the assertions clearer.
This commit is contained in:
Tim van der Meij
2026-09-13 15:47:00 +02:00
parent 15c9dc87f9
commit 8a024979f8
5 changed files with 7 additions and 22 deletions
+1 -4
View File
@@ -142,10 +142,7 @@ describe("FreeText Editor", () => {
y: rect.y + 100,
data,
});
await page.waitForFunction(
`document.getElementById("viewer-alert").textContent === "Text added"`
);
await waitForTextToBe(page, "#viewer-alert", "Text added");
let content = await page.$eval(editorSelector, el =>
el.innerText.trimEnd()
+1 -3
View File
@@ -74,9 +74,7 @@ describe("Highlight Editor", () => {
await switchToHighlight(page);
await highlightSpan(page, 1, "Abstract");
await page.waitForFunction(
`document.getElementById("viewer-alert").textContent === "Highlight added"`
);
await waitForTextToBe(page, "#viewer-alert", "Highlight added");
const oneToOne = Array.from(new Array(13).keys(), n => n + 2).concat(
Array.from(new Array(13).keys(), n => 13 - n)
+1 -5
View File
@@ -107,17 +107,13 @@ describe("Ink Editor", () => {
await switchToInk(page);
const rect = await getRect(page, ".annotationEditorLayer");
for (let i = 0; i < 3; i++) {
const x = rect.x + 100 + i * 100;
const y = rect.y + 100 + i * 100;
await drawLine(page, x, y, x + 50, y + 50);
await commit(page);
}
await page.waitForFunction(
`document.getElementById("viewer-alert").textContent === "Drawing added"`
);
await waitForTextToBe(page, "#viewer-alert", "Drawing added");
await clearAll(page);
+2 -4
View File
@@ -26,6 +26,7 @@ import {
PDI,
switchToEditor,
waitForPointerUp,
waitForTextToBe,
waitForTimeout,
} from "./test_utils.mjs";
import fs from "fs";
@@ -180,10 +181,7 @@ describe("Signature Editor", () => {
`.canvasWrapper > svg use[href="#path_0"]`,
{ visible: true }
);
await page.waitForFunction(
`document.getElementById("viewer-alert").textContent === "Signature added"`
);
await waitForTextToBe(page, "#viewer-alert", "Signature added");
// Check the tooltip.
await page.waitForSelector(
+2 -6
View File
@@ -118,15 +118,11 @@ describe("Stamp Editor", () => {
);
const editorSelector = getEditorSelector(0);
await waitForImage(page, editorSelector);
await page.waitForFunction(
`document.getElementById("viewer-alert").textContent === "Image added"`
);
const { width } = await getEditorDimensions(page, editorSelector);
await waitForTextToBe(page, "#viewer-alert", "Image added");
// The image is bigger than the page, so it has been scaled down to
// 75% of the page width.
const { width } = await getEditorDimensions(page, editorSelector);
expect(width).toEqual("75%");
const [bitmap] = await serializeBitmapDimensions(page);