Marmelator/pdf.js.mirror
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2026-06-12 13:11:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

Use FinalizationRegistry unconditionally in the src/scripting_api/app.js file

Browse Source 
After the QuickJS update in PR 20708 this code can now be simplified.
This commit is contained in:
Jonas Jenwald 2026-02-21 22:37:30 +01:00
parent b798fd8771
commit 956eb10329
1 changed files with 10 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/scripting_api/app.js
View File

@ -52,18 +52,14 @@ class App extends PDFObject {
);
this._timeoutIds = new WeakMap();
if (typeof FinalizationRegistry !== "undefined") {
// About setTimeOut/setInterval return values (specs):
// The return value of this method must be held in a
// JavaScript variable.
// Otherwise, the timeout object is subject to garbage-collection,
// which would cause the clock to stop.
this._timeoutIdsRegistry = new FinalizationRegistry(
this._cleanTimeout.bind(this)
);
} else {
this._timeoutIdsRegistry = null;
}
// About setTimeOut/setInterval return values (specs):
// The return value of this method must be held in a
// JavaScript variable.
// Otherwise, the timeout object is subject to garbage-collection,
// which would cause the clock to stop.
this._timeoutIdsRegistry = new FinalizationRegistry(
this._cleanTimeout.bind(this)
);
this._timeoutCallbackIds = new Map();
this._timeoutCallbackId = USERACTIVATION_CALLBACKID + 1;
@ -113,12 +109,12 @@ class App extends PDFObject {
const timeout = Object.create(null);
const id = { callbackId, interval };
this._timeoutIds.set(timeout, id);
this._timeoutIdsRegistry?.register(timeout, id);
this._timeoutIdsRegistry.register(timeout, id);
return timeout;
}
_unregisterTimeout(timeout) {
this._timeoutIdsRegistry?.unregister(timeout);
this._timeoutIdsRegistry.unregister(timeout);
const data = this._timeoutIds.get(timeout);
if (!data) {