Marmelator/pdf.js.mirror
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2026-10-04 06:18:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

Introduce a helper to reduce duplication when reading compiled buffer-data from fonts

Browse Source 
Currently the `FontInfo.prototype.{data, cssFontInfo, systemFontInfo}` getters duplicate virtually the same code when reading buffer-data, which seems completely unnecessary.

*Note:* This reduces the size of the `gulp mozcentral` bundle by `738` bytes, and with the upcoming worker-rendering this saving will be doubled.
This commit is contained in:
Jonas Jenwald
2026-10-02 15:25:09 +02:00
parent 20b2e11213
commit a00ad131fd
1 changed files with 15 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/display/obj_bin_transform_display.js
+15 -31
View File
@@ -228,28 +228,26 @@ class FontInfo {
return this.#readString(2);
}
#getDataOffsets() {
#getBufferOffset(index) {
let offset = FONT_INFO.OFFSET_STRINGS;
const stringsLength = this.#view.getUint32(offset);
offset += 4 + stringsLength;
const systemFontInfoLength = this.#view.getUint32(offset);
offset += 4 + systemFontInfoLength;
const cssFontInfoLength = this.#view.getUint32(offset);
offset += 4 + cssFontInfoLength;
// We need to move past any string-data first, hence the `<=` condition.
for (let i = 0; i <= index; i++) {
offset += 4 + this.#view.getUint32(offset);
}
const length = this.#view.getUint32(offset);
return { offset, length };
}
get data() {
const { offset, length } = this.#getDataOffsets();
const { offset, length } = this.#getBufferOffset(2);
return length === 0
? undefined
: new Uint8Array(this.#buffer, offset + 4, length);
}
clearData() {
const { offset, length } = this.#getDataOffsets();
const { offset, length } = this.#getBufferOffset(2);
if (length === 0) {
return; // The data is either not present, or it was previously cleared.
}
@@ -261,35 +259,21 @@ class FontInfo {
}
get cssFontInfo() {
let offset = FONT_INFO.OFFSET_STRINGS;
const stringsLength = this.#view.getUint32(offset);
offset += 4 + stringsLength;
const systemFontInfoLength = this.#view.getUint32(offset);
offset += 4 + systemFontInfoLength;
const cssFontInfoLength = this.#view.getUint32(offset);
if (cssFontInfoLength === 0) {
const { offset, length } = this.#getBufferOffset(1);
if (length === 0) {
return null;
}
const cssFontInfoData = new Uint8Array(cssFontInfoLength);
cssFontInfoData.set(
new Uint8Array(this.#buffer, offset + 4, cssFontInfoLength)
);
return new CssFontInfo(cssFontInfoData.buffer);
const data = new Uint8Array(this.#buffer, offset + 4, length).slice();
return new CssFontInfo(data.buffer);
}
get systemFontInfo() {
let offset = FONT_INFO.OFFSET_STRINGS;
const stringsLength = this.#view.getUint32(offset);
offset += 4 + stringsLength;
const systemFontInfoLength = this.#view.getUint32(offset);
if (systemFontInfoLength === 0) {
const { offset, length } = this.#getBufferOffset(0);
if (length === 0) {
return null;
}
const systemFontInfoData = new Uint8Array(systemFontInfoLength);
systemFontInfoData.set(
new Uint8Array(this.#buffer, offset + 4, systemFontInfoLength)
);
return new SystemFontInfo(systemFontInfoData.buffer);
const data = new Uint8Array(this.#buffer, offset + 4, length).slice();
return new SystemFontInfo(data.buffer);
}
}