From a443a635a12bb30d14c74bf85cdc0051d3f6595c Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Thu, 18 Jun 2026 17:47:26 +0200 Subject: [PATCH] Remove the unused `HTMLElement` branch in the `paintInlineImageXObject` method This branch isn't covered by any tests, and as far as I can tell it's been unused ever since PR 11601 which simplified the JPEG image handling. Prior to that we'd create an `Image` instance in one case, see [this code](https://github.com/mozilla/pdf.js/pull/11601/changes#diff-082d6b37ad01db7ac97cc07c6ddb0dc52040484c5ef91b110b072f50144d9f39L2312-L2314), which is why that branch was necessary since `new Image()` creates a `HTMLImageElement` instance which in itself is an instance of `HTMLElement`; note [this](https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/Image) respectively [this](https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement). --- src/display/canvas.js | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/display/canvas.js b/src/display/canvas.js index dc6eb165a..f77fe8a49 100644 --- a/src/display/canvas.js +++ b/src/display/canvas.js @@ -3996,12 +3996,6 @@ class CanvasGraphics { const result = this.applyTransferMapsToBitmap(imgData); imgToPaint = result.img; inlineImgCanvas = result.canvasEntry; - } else if ( - (typeof HTMLElement === "function" && imgData instanceof HTMLElement) || - !imgData.data - ) { - // typeof check is needed due to node.js support, see issue #8489 - imgToPaint = imgData; } else { const tmpCanvas = this.canvasFactory.create(width, height); putBinaryImageData(tmpCanvas.context, imgData);