Marmelator/pdf.js.mirror
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2026-05-31 07:11:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

Improve the performances of "gulp lint"

Browse Source 
Don't format json files with Prettier: it's done by eslint.
Parallelize the linting tools and eslint.
This commit is contained in:
calixteman 2026-04-26 23:03:53 +02:00
parent 53931c5d2f
commit a761dac3ea
No known key found for this signature in database
GPG Key ID: 0C5442631EE0691F
1 changed files with 23 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
gulpfile.mjs
View File

@ -2293,6 +2293,7 @@ gulp.task("lint", function (done) {
"node_modules/eslint/bin/eslint",
".",
"--report-unused-disable-directives",
"--concurrency=auto",
];
if (process.argv.includes("--fix")) {
esLintOptions.push("--fix");
@ -2307,9 +2308,11 @@ gulp.task("lint", function (done) {
styleLintOptions.push("--fix");
}
// JSON files are intentionally not passed to Prettier here: ESLint already
// formats them via its prettier/prettier rule (with identical output), and
// running both in parallel would race on writes in --fix mode.
const prettierOptions = [
"node_modules/prettier/bin/prettier.cjs",
"**/*.json",
"**/*.html",
];
if (process.argv.includes("--fix")) {
@ -2325,40 +2328,28 @@ gulp.task("lint", function (done) {
"--no-summary",
];
const esLintProcess = startNode(esLintOptions, { stdio: "inherit" });
esLintProcess.on("close", function (esLintCode) {
if (esLintCode !== 0) {
done(new Error("ESLint failed."));
function runLinter(name, options) {
return new Promise(resolve => {
const proc = startNode(options, { stdio: "inherit" });
proc.on("close", code => {
resolve(code === 0 ? null : name);
});
});
}
Promise.all([
runLinter("ESLint", esLintOptions),
runLinter("Stylelint", styleLintOptions),
runLinter("Prettier", prettierOptions),
runLinter("svglint", svgLintOptions),
]).then(results => {
const failures = results.filter(Boolean);
if (failures.length) {
done(new Error(`${failures.join(", ")} failed.`));
return;
}
const styleLintProcess = startNode(styleLintOptions, { stdio: "inherit" });
styleLintProcess.on("close", function (styleLintCode) {
if (styleLintCode !== 0) {
done(new Error("Stylelint failed."));
return;
}
const prettierProcess = startNode(prettierOptions, { stdio: "inherit" });
prettierProcess.on("close", function (prettierCode) {
if (prettierCode !== 0) {
done(new Error("Prettier failed."));
return;
}
const svgLintProcess = startNode(svgLintOptions, {
stdio: "inherit",
});
svgLintProcess.on("close", function (svgLintCode) {
if (svgLintCode !== 0) {
done(new Error("svglint failed."));
return;
}
gulp.task("lint-licenses")(done);
});
});
});
gulp.task("lint-licenses")(done);
});
});