From c7bdf5b508bd0dbfb48eaf23ce9feb6fdebb8380 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sat, 21 Feb 2026 12:00:19 +0100 Subject: [PATCH 1/2] Use `Map.prototype.getOrInsertComputed()` in the `ensureDebugMetadata` helper Also, shorten the function by using optional chaining. --- src/display/canvas_dependency_tracker.js | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/src/display/canvas_dependency_tracker.js b/src/display/canvas_dependency_tracker.js index 0d391c406..a8cc33505 100644 --- a/src/display/canvas_dependency_tracker.js +++ b/src/display/canvas_dependency_tracker.js @@ -50,17 +50,11 @@ class BBoxReader { } } -const ensureDebugMetadata = (map, key) => { - if (!map) { - return undefined; - } - let value = map.get(key); - if (!value) { - value = { dependencies: new Set(), isRenderingOperation: false }; - map.set(key, value); - } - return value; -}; +const ensureDebugMetadata = (map, key) => + map?.getOrInsertComputed(key, () => ({ + dependencies: new Set(), + isRenderingOperation: false, + })); /** * @typedef {"lineWidth" | "lineCap" | "lineJoin" | "miterLimit" | "dash" | From 0d8bc689b9ab354f719589fbafd39ceeed472464 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sat, 21 Feb 2026 13:26:20 +0100 Subject: [PATCH 2/2] Add missing license header in `src/display/canvas_dependency_tracker.js` --- src/display/canvas_dependency_tracker.js | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/display/canvas_dependency_tracker.js b/src/display/canvas_dependency_tracker.js index a8cc33505..40c93417b 100644 --- a/src/display/canvas_dependency_tracker.js +++ b/src/display/canvas_dependency_tracker.js @@ -1,3 +1,18 @@ +/* Copyright 2025 Mozilla Foundation + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + import { Util } from "../shared/util.js"; const FORCED_DEPENDENCY_LABEL = "__forcedDependency";