Marmelator/pdf.js.mirror
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2026-02-08 00:21:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Return the rawFilename as-is even if it's empty, from FileSpec.prototype.serializable

Browse Source 
It's more correct to return the `rawFilename` as-is, and limit the fallback for empty filenames to only the `filename` property.
This commit is contained in:
Jonas Jenwald 2026-01-25 13:16:48 +01:00
parent 640a3106d5
commit b3f35b6007
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/core/file_spec.js
View File

@ -65,14 +65,15 @@ class FileSpec {
get filename() {
const item = pickPlatformItem(this.root);
let name;
if (item && typeof item === "string") {
name = stringToPDFString(item, /* keepEscapeSequence = */ true)
// NOTE: The following replacement order is INTENTIONAL, regardless of
// what some static code analysers (e.g. CodeQL) may claim.
return stringToPDFString(item, /* keepEscapeSequence = */ true)
.replaceAll("\\\\", "\\")
.replaceAll("\\/", "/")
.replaceAll("\\", "/");
}
return name || "unnamed";
return "";
}
get content() {
@ -100,7 +101,7 @@ class FileSpec {
const { filename, content, description } = this;
return {
rawFilename: filename,
filename: stripPath(filename),
filename: stripPath(filename) || "unnamed",
content,
description,
};