From b4b0a3fa0460664949d9e3dc3f95166a6b9c3e35 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Thu, 18 Jun 2026 17:59:57 +0200 Subject: [PATCH] Remove the unused `ImageData` branch in the `putBinaryImageData` function This branch isn't covered by any tests, and looking at the two existing call-sites we only ever pass in a `CanvasRenderingContext2D` interface to this function. Based on the git history this branch was added in PR 3312, however as far as I can tell it doesn't actually appear to have been necessary even back then!? --- src/display/canvas.js | 5 ----- src/display/node_utils.js | 7 ------- 2 files changed, 12 deletions(-) diff --git a/src/display/canvas.js b/src/display/canvas.js index f77fe8a49..47d2a296f 100644 --- a/src/display/canvas.js +++ b/src/display/canvas.js @@ -320,11 +320,6 @@ class CanvasExtraState { } function putBinaryImageData(ctx, imgData) { - if (imgData instanceof ImageData) { - ctx.putImageData(imgData, 0, 0); - return; - } - // Put the image data to the canvas in chunks, rather than putting the // whole image at once. This saves JS memory, because the ImageData object // is smaller. It also possibly saves C++ memory within the implementation diff --git a/src/display/node_utils.js b/src/display/node_utils.js index 156832c9f..470f2c480 100644 --- a/src/display/node_utils.js +++ b/src/display/node_utils.js @@ -51,13 +51,6 @@ if (isNodeJS) { warn("Cannot polyfill `DOMMatrix`, rendering may be broken."); } } - if (!globalThis.ImageData) { - if (canvas?.ImageData) { - globalThis.ImageData = canvas.ImageData; - } else { - warn("Cannot polyfill `ImageData`, rendering may be broken."); - } - } if (!globalThis.Path2D) { if (canvas?.Path2D) { globalThis.Path2D = canvas.Path2D;