From bfffb6c0f0503e51fd2ab6145e11b6eb34ebf969 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Mon, 30 Mar 2026 14:03:09 +0200 Subject: [PATCH] Import `fs/promises` directly in a few spots in the unit-tests Also, use the existing PDF.js helper function to fetch text-data when running the "bidi" tests in browsers. --- src/display/node_utils.js | 4 ++-- test/unit/bidi_spec.js | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/display/node_utils.js b/src/display/node_utils.js index 67e0de0fb..156832c9f 100644 --- a/src/display/node_utils.js +++ b/src/display/node_utils.js @@ -76,8 +76,8 @@ if (isNodeJS) { } async function fetchData(url) { - const fs = process.getBuiltinModule("fs"); - const data = await fs.promises.readFile(url); + const fs = process.getBuiltinModule("fs/promises"); + const data = await fs.readFile(url); return new Uint8Array(data); } diff --git a/test/unit/bidi_spec.js b/test/unit/bidi_spec.js index 6b823aa8f..5c600095c 100644 --- a/test/unit/bidi_spec.js +++ b/test/unit/bidi_spec.js @@ -14,6 +14,7 @@ */ import { bidi } from "../../src/core/bidi.js"; +import { fetchData } from "../../src/display/display_utils.js"; import { isNodeJS } from "../../src/shared/util.js"; const BIDI_TEST_DATA_PATH = isNodeJS ? "./test/bidi/" : "../bidi/"; @@ -21,11 +22,10 @@ const BIDI_TEST_DATA_PATH = isNodeJS ? "./test/bidi/" : "../bidi/"; async function readTestFile(filename) { const path = BIDI_TEST_DATA_PATH + filename; if (isNodeJS) { - const fs = process.getBuiltinModule("fs"); - return fs.promises.readFile(path, "utf8"); + const fs = process.getBuiltinModule("fs/promises"); + return fs.readFile(path, "utf8"); } - const response = await fetch(new URL(path, window.location)); - return response.text(); + return fetchData(new URL(path, window.location), /* type = */ "text"); } // Unicode Bidirectional Algorithm tests.