Marmelator/pdf.js.mirror
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2026-06-23 00:15:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix intermittent failure in the must check that the comment sidebar is resizable comment integration test

Browse Source 
We use the generic `page.mouse.move(x, y, { steps }` API, but that purely
performs the mouse move steps without having knowledge about if/how the
application handles any events caused by it, so it doesn't wait for the
sidebar to render before moving on. This causes intermittent failures if
the sidebar didn't get enough time to render before the next mouse move
is initiated (which can happen in slower environments).

This commit fixes the issue by doing the mouse move steps ourselves and
by waiting for a browser trip between each of them to make sure that the
sidebar got a chance to render.

Fixes #21447.
Relates to #21044 / #21045 / 24e5377.
This commit is contained in:
Tim van der Meij 2026-06-13 20:59:45 +02:00
parent 86a18bd5fe
commit d305b542df
No known key found for this signature in database
GPG Key ID: 8C3FD2925A5F2762
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/integration/comment_spec.mjs
View File

@ -537,7 +537,11 @@ describe("Comment", () => {
await page.mouse.down();
const steps = 20;
await page.mouse.move(startX - extraWidth, startY, { steps });
for (let i = 1; i <= steps; i++) {
const x = Math.round(startX - (extraWidth * i) / steps);
await page.mouse.move(x, startY);
await waitForBrowserTrip(page);
}
await page.mouse.up();
const rectAfter = await getRect(page, sidebarSelector);