Marmelator/pdf.js.mirror
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2026-06-12 21:21:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #20679 from calixteman/bug2016142

Browse Source 
Add an aria-label to the sidebar resizer (bug 2016142)
This commit is contained in:
calixteman 2026-02-18 16:33:53 +01:00 committed by GitHub
commit e331d458cb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
l10n/en-US/viewer.ftl
View File

@ -698,6 +698,8 @@ pdfjs-toggle-views-manager-button-label = Toggle Sidebar
pdfjs-views-manager-sidebar =
.aria-label = Sidebar
pdfjs-views-manager-sidebar-resizer =
.aria-label = Sidebar resizer
pdfjs-views-manager-view-selector-button =
.title = Views
pdfjs-views-manager-view-selector-button-label = Views

15
test/integration/thumbnail_view_spec.mjs
View File

@ -58,6 +58,21 @@ describe("PDF Thumbnail View", () => {
})
);
});
it("should have accessible label on resizer", async () => {
await Promise.all(
pages.map(async ([browserName, page]) => {
await page.click("#viewsManagerToggleButton");
const ariaLabel = await page.$eval("#viewsManagerResizer", el =>
el.getAttribute("aria-label")
);
expect(ariaLabel)
.withContext(`In ${browserName}`)
.toBe("Sidebar resizer");
})
);
});
});
describe("The view is scrolled correctly", () => {

9
web/viewer.html
View File

@ -278,7 +278,14 @@ See https://github.com/adobe-type-tools/cmap-resources
<div id="attachmentsView" class="hidden"></div>
<div id="layersView" class="treeView hidden"></div>
</div>
<div id="viewsManagerResizer" class="sidebarResizer" role="separator" aria-controls="viewsManager" tabindex="0"></div>
<div
id="viewsManagerResizer"
class="sidebarResizer"
role="separator"
aria-controls="viewsManager"
tabindex="0"
data-l10n-id="pdfjs-views-manager-sidebar-resizer"
></div>
</div>
<!-- sidebarContainer -->