From 3940855511a105e5e6b1967ea85143d893282d8d Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sat, 21 Feb 2026 11:29:29 +0100 Subject: [PATCH] Use `Map.prototype.getOrInsert()` in the `_getPageAdvance` method Also, change the method to an actually private one. --- web/pdf_viewer.js | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/web/pdf_viewer.js b/web/pdf_viewer.js index c22ede2c2..a3b28220a 100644 --- a/web/pdf_viewer.js +++ b/web/pdf_viewer.js @@ -2270,10 +2270,7 @@ class PDFViewer { this.update(); } - /** - * @private - */ - _getPageAdvance(currentPageNumber, previous = false) { + #getPageAdvance(currentPageNumber, previous = false) { switch (this._scrollMode) { case ScrollMode.WRAPPED: { const { views } = this._getVisiblePages(), @@ -2284,11 +2281,7 @@ class PDFViewer { if (percent === 0 || widthPercent < 100) { continue; } - let yArray = pageLayout.get(y); - if (!yArray) { - pageLayout.set(y, (yArray ||= [])); - } - yArray.push(id); + pageLayout.getOrInsert(y, []).push(id); } // Find the row of the current page. for (const yArray of pageLayout.values()) { @@ -2379,7 +2372,7 @@ class PDFViewer { return false; } const advance = - this._getPageAdvance(currentPageNumber, /* previous = */ false) || 1; + this.#getPageAdvance(currentPageNumber, /* previous = */ false) || 1; this.currentPageNumber = Math.min(currentPageNumber + advance, pagesCount); return true; @@ -2396,7 +2389,7 @@ class PDFViewer { return false; } const advance = - this._getPageAdvance(currentPageNumber, /* previous = */ true) || 1; + this.#getPageAdvance(currentPageNumber, /* previous = */ true) || 1; this.currentPageNumber = Math.max(currentPageNumber - advance, 1); return true;