Marmelator/pdf.js.mirror
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2026-07-28 18:07:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add missing startWorkerTask calls in the "SaveDocument" handler

Browse Source 
Without these calls we'll not actually wait for saving to complete when document destruction runs; compare with other `WorkerTask`-usage in this file.
While I cannot imagine that this has caused any problems for library users, the code is however not technically correct as-is.
This commit is contained in:
Jonas Jenwald 2024-12-21 14:15:28 +01:00
parent dd5618ebed
commit ec1a05c104
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/core/worker.js
View File

@ -177,6 +177,7 @@ class WorkerMessageHandler {
if (isPureXfa) { if (isPureXfa) {
const task = new WorkerTask("loadXfaFonts"); const task = new WorkerTask("loadXfaFonts");
startWorkerTask(task); startWorkerTask(task);
await Promise.all([ await Promise.all([
pdfManager pdfManager
.loadXfaFonts(handler, task) .loadXfaFonts(handler, task)
@ -590,6 +591,8 @@ class WorkerMessageHandler {
newAnnotationPromises.push( newAnnotationPromises.push(
pdfManager.getPage(pageIndex).then(page => { pdfManager.getPage(pageIndex).then(page => {
const task = new WorkerTask(`Save (editor): page ${pageIndex}`); const task = new WorkerTask(`Save (editor): page ${pageIndex}`);
startWorkerTask(task);
return page return page
.saveNewAnnotations( .saveNewAnnotations(
handler, handler,
@ -637,6 +640,8 @@ class WorkerMessageHandler {
promises.push( promises.push(
pdfManager.getPage(pageIndex).then(function (page) { pdfManager.getPage(pageIndex).then(function (page) {
const task = new WorkerTask(`Save: page ${pageIndex}`); const task = new WorkerTask(`Save: page ${pageIndex}`);
startWorkerTask(task);
return page return page
.save(handler, task, annotationStorage, changes) .save(handler, task, annotationStorage, changes)
.finally(function () { .finally(function () {