Marmelator/pdf.js.mirror
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2026-04-10 07:14:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove the unused bbox setter in the FontFaceObject class (PR 20427 follow-up)

Browse Source 
The commit message for the patch in PR 20427 is pretty non-descriptive, being only a single line, however there's a bit more context in https://github.com/mozilla/pdf.js/pull/20427#issue-3597370951 but unfortunately the details there don't really make sense.
Note that the PR only changed main-thread code, but all the links are to worker-thread code!?

The `FontFaceObject` class is only used on the main-thread, and when encountering a broken font we fallback to the built-in font renderer; see 820b70eb25/src/display/font_loader.js (L135-L143)
Hence the `FontFaceObject` class *only* needs a way to set the `disableFontFace` property, however nowhere on the main-thread do we ever update the `bbox` of a font.
This commit is contained in:
Jonas Jenwald 2026-03-14 09:54:59 +01:00
parent 1192e5e921
commit f1e1973e6f
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/display/font_loader.js
View File

@ -507,10 +507,6 @@ class FontFaceObject {
return this.#fontData.bbox;
}
set bbox(bbox) {
shadow(this, "bbox", bbox);
}
get fontMatrix() {
return this.#fontData.fontMatrix;
}