From f373fbfa5b5601bb2dd1cc27e67f6411076395f7 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Fri, 3 Jul 2026 00:03:17 +0200 Subject: [PATCH] Reduce duplication when updating undoButton/undoCloseButton in `PDFThumbnailViewer.prototype.#updateStatus` --- web/pdf_thumbnail_viewer.js | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/web/pdf_thumbnail_viewer.js b/web/pdf_thumbnail_viewer.js index cc22c8e09..b31e8d87d 100644 --- a/web/pdf_thumbnail_viewer.js +++ b/web/pdf_thumbnail_viewer.js @@ -1215,19 +1215,14 @@ class PDFThumbnailViewer { } this.#toggleBar("undo", l10nId, { count }); - if (type === "copy") { - this.#undoButton.firstElementChild.setAttribute( - "data-l10n-id", - "pdfjs-views-manager-status-done-button-label" - ); - this.#undoCloseButton.classList.toggle("hidden", true); - } else { - this.#undoButton.firstElementChild.setAttribute( - "data-l10n-id", - "pdfjs-views-manager-status-undo-button-label" - ); - this.#undoCloseButton.classList.toggle("hidden", false); - } + const isCopy = type === "copy"; + this.#undoButton.firstElementChild.setAttribute( + "data-l10n-id", + isCopy + ? "pdfjs-views-manager-status-done-button-label" + : "pdfjs-views-manager-status-undo-button-label" + ); + this.#undoCloseButton.classList.toggle("hidden", isCopy); } #moveDraggedContainer(dx, dy) {