Marmelator/pdf.js.mirror
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2026-04-09 23:04:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Use optional chaining rather than typeof checks when invoking the AnnotationStorage callbacks

Browse Source 
This is a little bit shorter, and it should be fine considering that in the API there are no `typeof` checks when invoking user-provided callbacks (see e.g. `onPassword` and `onProgress`).
This commit is contained in:
Jonas Jenwald 2026-03-25 13:47:49 +01:00
parent 777251da85
commit fc3407cabd
1 changed files with 6 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/display/annotation_storage.js
View File

@ -100,14 +100,10 @@ class AnnotationStorage {
this.resetModified();
}
if (typeof this.onAnnotationEditor === "function") {
for (const value of this.#storage.values()) {
if (value instanceof AnnotationEditor) {
return;
}
}
this.onAnnotationEditor(null);
if (this.#storage.values().some(v => v instanceof AnnotationEditor)) {
return;
}
this.onAnnotationEditor?.(null);
}
/**
@ -135,9 +131,7 @@ class AnnotationStorage {
if (value instanceof AnnotationEditor) {
(this.#editorsMap ||= new Map()).set(value.annotationElementId, value);
if (typeof this.onAnnotationEditor === "function") {
this.onAnnotationEditor(value.constructor._type);
}
this.onAnnotationEditor?.(value.constructor._type);
}
}
@ -157,18 +151,14 @@ class AnnotationStorage {
#setModified() {
if (!this.#modified) {
this.#modified = true;
if (typeof this.onSetModified === "function") {
this.onSetModified();
}
this.onSetModified?.();
}
}
resetModified() {
if (this.#modified) {
this.#modified = false;
if (typeof this.onResetModified === "function") {
this.onResetModified();
}
this.onResetModified?.();
}
}