Marmelator/pdf.js.mirror
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2026-04-15 01:34:02 +02:00
Code Issues Packages Projects Releases Wiki Activity
21,220 Commits 1 Branch 105 Tags
Commit Graph

454 Commits

Author SHA1 Message Date
Calixte Denizet
0b40bf1743 [Editor] Update the color and the position of the comment button in reading mode they've been modified 2025-09-24 09:45:37 +02:00
calixteman
48c10d8938
Merge pull request #20285 from calixteman/editor_remove_useless_dim_stuff 
[Editor] Remove useless computations when setting the dimensions of an editor
 2025-09-23 20:26:12 +02:00
calixteman
225b07aa29
Merge pull request #20283 from calixteman/bug1989304 
[Editor] Make sure the comment dialog is visible on the screen (bug 1989304)
 2025-09-23 19:30:28 +02:00
Calixte Denizet
0722faa9ce [Editor] Remove useless computations when setting the dimensions of an editor 
And remove an unused functions AnnotationEditor::setAspectRatio/fixDims.
 2025-09-19 18:08:56 +02:00
Calixte Denizet
623d422ddb [Editor] Make sure the comment dialog is visible on the screen (bug 1989304) 2025-09-18 21:23:42 +02:00
Calixte Denizet
cbc5241b53 [Editor] Make sure to not add extra editors when showing again a destroyed page 2025-09-18 15:18:50 +02:00
Tim van der Meij
d85fd12437
Merge pull request #20274 from calixteman/save_comment_reading_mode 
[Annotation] Save the comment changes made in reading mode (bug 1987427)
 2025-09-15 23:32:51 +02:00
Calixte Denizet
764c2e639c [Editor] Fix the position of the comment popup and its dialog 
Only fix the popup position if the user didn't change it.
And don't adjust the dialog position since it should have the same as the popup.
 2025-09-15 21:26:36 +02:00
Calixte Denizet
5feb4674d6 [Annotation] Save the comment changes made in reading mode (bug 1987427) 2025-09-15 19:49:49 +02:00
Calixte Denizet
38b86cb97a [Annotation] Use the new popup in reading mode (bug 1987426) 2025-09-15 16:58:22 +02:00
Calixte Denizet
b660b721f9 [Editor] Add a new popup for comments (bug 1987425) 
And:
 - improve the editing dialog in removing menu;
 - position correctly the popup on the left/right depending on the direction value.
 2025-09-15 08:24:26 +02:00
calixteman
d77f89026f
Merge pull request #20240 from calixteman/fix_contrast 
Make sure that a good constrast ratio is respected when darkening/lightening a color
 2025-09-12 09:24:40 +02:00
Calixte Denizet
7f85c00ee6 Make sure that a good constrast ratio is respected when darkening/lightening a color 2025-09-11 21:29:28 +02:00
calixteman
5b7f9ca8b9
Merge pull request #20247 from calixteman/wait_for_rendered_editors 
[Editor] When clicking on a comment in the sidebar, wait for the annotation editor layer to be rendered
 2025-09-09 09:26:45 +02:00
calixteman
d009c434f5
Merge pull request #20248 from calixteman/toolbar_button_position 
[Editor] Make sure the comment button is at the right place when adding it in the toolbar
 2025-09-08 23:06:02 +02:00
calixteman
17a27806c6
Merge pull request #20245 from calixteman/comment_richtext 
[Editor] Add the dates and rich text if any to the editors in order to use them when displaying the popup
 2025-09-08 22:23:03 +02:00
Calixte Denizet
f5c913bc9e [Editor] Make sure the comment button is at the right place when adding it in the toolbar 2025-09-08 17:59:28 +02:00
Calixte Denizet
94d72e903f [Editor] Add the dates and rich text if any to the editors in order to use them when displaying the popup 2025-09-08 17:40:47 +02:00
Calixte Denizet
54351ee437 [Editor] When clicking on a comment in the sidebar, wait for the annotation editor layer to be rendered 
and add a getter for the layer bounding rect.
 2025-09-08 17:13:37 +02:00
Calixte Denizet
2d5794f79d [Editor] Fix saving a deleted popup 2025-09-08 15:36:41 +02:00
calixteman
7b87c220a5
Merge pull request #20233 from calixteman/dont_add_image_stamp_update 
[Editor] Don't save the image when updating a stamp annotation
 2025-09-04 22:19:36 +02:00
Calixte Denizet
2354ae4233 [Editor] Don't save the image when updating a stamp annotation 
It adds some useless bytes in the file.
 2025-09-04 18:54:13 +02:00
Calixte Denizet
ca280399c2 [Editor] Use the color of the annotation for the background of the comment button 2025-09-02 21:17:08 +02:00
Calixte Denizet
2a459857ce [Editor] Add editors with a comment in the sidebar 
and add a button close to the editor.
Clicking on the button will display a popup with the comment but it's for a next patch.
 2025-08-31 19:59:16 +02:00
Calixte Denizet
25990e4287 [Editor] Add a sidebar allowing the user to navigate between the comments in a pdf (bug 1985567) 
This implements what has been specified but it's still not done: we have to handle editing a comment
or an annotation containing one.
 2025-08-29 16:00:06 +02:00
Calixte Denizet
1fc039e14f [Editor] Add a method to get an editor rect in the pdf page coordinates 2025-08-26 19:40:41 +02:00
Tim van der Meij
eec1bea1b4
[Editor] Don't use a null signal for the comment button 
This removes the following error from the integration test logs:

```
JavaScript error: http://127.0.0.1:59283/build/generic/build/pdf.mjs, line 3879:
TypeError: EventTarget.addEventListener: 'signal' member of AddEventListenerOptions is not an object.
```

Fixes 636ff50.
Extends 63651885.
 2025-08-24 20:01:10 +02:00
calixteman
592d6c070a
Merge pull request #20179 from calixteman/add_rect_popup 
[Editor] Add a Rect entry to a saved popup in order to avoid to have an invalid pdf
 2025-08-24 12:01:31 +02:00
Calixte Denizet
f8466c9ff8 [Editor] Add a Rect entry to a saved popup in order to avoid to have an invalid pdf 2025-08-20 17:56:50 +02:00
Calixte Denizet
f8ea63606c [Editor] Move the comment button just before the delete one 2025-08-20 17:18:38 +02:00
Tim van der Meij
c6bd044438
Merge pull request #20164 from calixteman/editor_hide_deleted_annotation 
[Editor] Correctly hide deleted annotations
 2025-08-14 20:39:39 +02:00
Calixte Denizet
6365188535 [Editor] Avoid to use a null signal when setting listeners in the editor toolbar 
It should fix the error:
```
JavaScript error: http://127.0.0.1:43303/build/generic/build/pdf.mjs, line 1445:
TypeError: EventTarget.addEventListener: 'signal' member of AddEventListenerOptions is not an object.
```

we've when running integration tests on the Linux bot.
 2025-08-14 15:07:22 +02:00
Calixte Denizet
6a00174688 [Editor] Correctly hide deleted annotations 2025-08-13 22:41:19 +02:00
Calixte Denizet
a81e99168a [Editor] Highlight text on a selectionchange event which hasn't been triggered by the pointer or the keyboard (bug 1976597) 
It's useful for users highlighting with NVDA.
They've to enable native selection and then selection some text.
In this case only a selectionchange is triggered once the selection is done.
 2025-07-31 21:03:32 +02:00
Calixte Denizet
3fb7cd40e7 [Editor] Add a floating button in order to highlight the text selection and add a comment (bug 1979381) 
The callback called when clicking on the button is the same as the one trigged by clicking in the context menu (in m-c).
 2025-07-28 15:32:23 +02:00
Calixte Denizet
c022a3294a [Editor] Fix the highlighting colors in HCM (bug 1977259) 
Using the same color in HCM or non-HCM was inducing a too small contrast between
some bg/fg colors making the text a bit hard to read.
 2025-07-18 20:11:28 +02:00
Tim van der Meij
23bd705cea
Merge pull request #20080 from calixteman/add_comment_1 
[Editor] Add the possibility to add Popup annotations (bug 1976724)
 2025-07-17 21:07:06 +02:00
Calixte Denizet
5162209b27 [Editor] Make possible to change the highlight color from the main panel 
It's consistent with the way to change colors for FreeText or Ink annotations.
 2025-07-17 20:57:51 +02:00
Calixte Denizet
636ff503ff [Editor] Add the possibility to add Popup annotations (bug 1976724) 
It's a first big step.
This patch contains a new modal dialog to let the user edit/update a Popup
 2025-07-15 22:39:16 +02:00
calixteman
4f2390a607
Merge pull request #20070 from calixteman/editor_toolbar_color 
[Editor] Add a color picker in the toolbar of Ink and Freetext annotations
 2025-07-14 23:55:51 +02:00
Calixte Denizet
dbd6f8cdd4 [Editor] Add a color picker in the toolbar of Ink and Freetext annotations 2025-07-14 23:00:01 +02:00
calixteman
ac2a0c5080
Merge pull request #20085 from calixteman/bug1975719 
Handle the case where all the image data are in the alpha channel (bug 1975719)
 2025-07-14 22:44:19 +02:00
Tim van der Meij
64b150f78f
Merge pull request #20077 from calixteman/remove_popup 
[Editor] Remove a popup from the DOM when it's deleted
 2025-07-12 15:25:49 +02:00
Calixte Denizet
6f8796d2c8 Handle the case where all the image data are in the alpha channel (bug 1975719) 
and add an error message in case where there is no data in the image.
 2025-07-11 22:34:37 +02:00
Calixte Denizet
b07914843b [Editor] Remove a popup from the DOM when it's deleted 2025-07-11 21:55:14 +02:00
Calixte Denizet
0f504d9a1a Add the l10n parameter when pasting a Signature annotation 2025-07-10 21:01:24 +02:00
Tim van der Meij
b999d5ce58
Merge pull request #20060 from noritaka1166/fix-typos 
Fix typos across the codebase
 2025-07-08 18:28:52 +02:00
Noritaka Kobayashi
fa568e826d
Fix typos across the codebase 2025-07-07 09:59:36 +09:00
Calixte Denizet
6d2c6cfc9f [Editor] Allow to change the editor mode when selecting the corresponding editor (bug 1975538) 
For example, selecting an ink editor just after having created a freetext will switch to ink mode.
 2025-07-03 23:27:34 +02:00
Calixte Denizet
c22a425b04 [Editor] When an annotation is added, announce it if the user is using a screen reader (bug 1975264) 2025-07-03 16:53:01 +02:00