Merge pull request #19685 from calixteman/issue19424

[Editor] Take into account the parent rotation when switch to edit mode (issue #19424)

src/display/editor/highlight.js

@@ -984,6 +984,7 @@ class HighlightEditor extends AnnotationEditor {
         clipPathId,
       });
       editor.#addToDrawLayer();
+      editor.rotate(editor.parentRotation);
     }
 
     return editor;

test/integration/highlight_editor_spec.mjs

@@ -2674,4 +2674,34 @@ describe("Highlight Editor", () => {
       );
     });
   });
+
+  describe("Highlight must be rotated when existing in the pdf", () => {
+    let pages;
+
+    beforeAll(async () => {
+      pages = await loadAndWait("issue19424.pdf", ".annotationEditorLayer");
+    });
+
+    afterAll(async () => {
+      await closePages(pages);
+    });
+
+    it("must check that there is no scroll because of focus", async () => {
+      await Promise.all(
+        pages.map(async ([browserName, page]) => {
+          await page.evaluate(() => {
+            window.PDFViewerApplication.rotatePages(90);
+          });
+          await page.waitForSelector(
+            ".annotationEditorLayer[data-main-rotation='90']"
+          );
+          await switchToHighlight(page);
+
+          await page.waitForSelector(
+            ".canvasWrapper svg[data-main-rotation='90']"
+          );
+        })
+      );
+    });
+  });
 });

test/pdfs/.gitignore

@@ -713,3 +713,4 @@
 !colors.pdf
 !red_stamp.pdf
 !issue19633.pdf
+!issue19424.pdf

web/signature_manager.js

@@ -187,10 +187,10 @@ class SignatureManager {
       },
       { passive: true }
     );
-    description.addEventListener(
+    this.#description.addEventListener(
       "input",
       () => {
-        this.#clearDescription.disabled = description.value === "";
+        this.#clearDescription.disabled = this.#description.value === "";
       },
       { passive: true }
     );

web/viewer.html

@@ -716,9 +716,9 @@ See https://github.com/adobe-type-tools/cmap-resources
               <div id="addSignatureControls">
                 <div id="horizontalContainer">
                   <div id="addSignatureDescriptionContainer">
-                    <label for="addSignatureDescription" data-l10n-id="pdfjs-editor-add-signature-description-label"></span></label>
+                    <label for="addSignatureDescInput" data-l10n-id="pdfjs-editor-add-signature-description-label"></label>
                     <span id="addSignatureDescription" class="inputWithClearButton">
-                      <input type="text" data-l10n-id="pdfjs-editor-add-signature-description-input" tabindex="0"></input>
+                      <input id="addSignatureDescInput" type="text" data-l10n-id="pdfjs-editor-add-signature-description-input" tabindex="0"></input>
                       <button class="clearInputButton" type="button" tabindex="0" aria-hidden="true"></button>
                     </span>
                   </div>
@@ -755,9 +755,9 @@ See https://github.com/adobe-type-tools/cmap-resources
           </div>
           <div id="editSignatureDescriptionAndView">
             <div id="editSignatureDescriptionContainer">
-              <label for="editSignatureDescription" data-l10n-id="pdfjs-editor-add-signature-description-label"></span></label>
+              <label for="editSignatureDescInput" data-l10n-id="pdfjs-editor-add-signature-description-label"></label>
               <span id="editSignatureDescription" class="inputWithClearButton">
-                <input type="text" data-l10n-id="pdfjs-editor-add-signature-description-input" tabindex="0"></input>
+                <input id="editSignatureDescInput" type="text" data-l10n-id="pdfjs-editor-add-signature-description-input" tabindex="0"></input>
                 <button class="clearInputButton" type="button" tabindex="0" aria-hidden="true"></button>
               </span>
             </div>