src/core/catalog.js

@@ -1062,13 +1062,11 @@ class Catalog {
     if (obj instanceof Dict && obj.has("XFAImages")) {
       const nameTree = new NameTree(obj.getRaw("XFAImages"), this.xref);
       for (const [key, value] of nameTree.getAll()) {
-        if (value instanceof BaseStream) {
-          xfaImages ??= new Map();
-          xfaImages.set(
-            stringToPDFString(key, /* keepEscapeSequence = */ true),
-            value.getBytes()
-          );
-        }
+        xfaImages ??= new Dict(this.xref);
+        xfaImages.set(
+          stringToPDFString(key, /* keepEscapeSequence = */ true),
+          value
+        );
       }
     }
     return shadow(this, "xfaImages", xfaImages);

src/core/document.js

@@ -1237,15 +1237,28 @@ class PDFDocument {
     return this.xfaFactory ? this.xfaFactory.getPages() : null;
   }
 
-  async #loadXfaImages() {
-    const xfaImages = await this.pdfManager.ensureCatalog("xfaImages");
-    if (!xfaImages) {
+  async loadXfaImages() {
+    const xfaImagesDict = await this.pdfManager.ensureCatalog("xfaImages");
+    if (!xfaImagesDict) {
       return;
     }
+
+    const keys = xfaImagesDict.getKeys();
+    const objectLoader = new ObjectLoader(xfaImagesDict, keys, this.xref);
+    await objectLoader.load();
+
+    const xfaImages = new Map();
+    for (const key of keys) {
+      const stream = xfaImagesDict.get(key);
+      if (stream instanceof BaseStream) {
+        xfaImages.set(key, stream.getBytes());
+      }
+    }
+
     this.xfaFactory.setImages(xfaImages);
   }
 
-  async #loadXfaFonts(handler, task) {
+  async loadXfaFonts(handler, task) {
     const acroForm = await this.pdfManager.ensureCatalog("acroForm");
     if (!acroForm) {
       return;
@@ -1264,19 +1277,18 @@ class PDFDocument {
 
     const options = Object.assign(
       Object.create(null),
-      this.pdfManager.evaluatorOptions,
-      { useSystemFonts: false }
+      this.pdfManager.evaluatorOptions
     );
-    const { builtInCMapCache, fontCache, standardFontDataCache } = this.catalog;
+    options.useSystemFonts = false;
 
     const partialEvaluator = new PartialEvaluator({
       xref: this.xref,
       handler,
       pageIndex: -1,
       idFactory: this._globalIdFactory,
-      fontCache,
-      builtInCMapCache,
-      standardFontDataCache,
+      fontCache: this.catalog.fontCache,
+      builtInCMapCache: this.catalog.builtInCMapCache,
+      standardFontDataCache: this.catalog.standardFontDataCache,
       options,
     });
     const operatorList = new OperatorList();
@@ -1293,23 +1305,6 @@ class PDFDocument {
       },
     };
 
-    const parseFont = (fontName, fallbackFontDict, cssFontInfo) =>
-      partialEvaluator
-        .handleSetFont(
-          resources,
-          [Name.get(fontName), 1],
-          /* fontRef = */ null,
-          operatorList,
-          task,
-          initialState,
-          fallbackFontDict,
-          cssFontInfo
-        )
-        .catch(reason => {
-          warn(`loadXfaFonts: "${reason}".`);
-          return null;
-        });
-
     const promises = [];
     for (const [fontName, font] of fontRes) {
       const descriptor = font.get("FontDescriptor");
@@ -1331,7 +1326,21 @@ class PDFDocument {
         continue;
       }
       promises.push(
-        parseFont(fontName, /* fallbackFontDict = */ null, cssFontInfo)
+        partialEvaluator
+          .handleSetFont(
+            resources,
+            [Name.get(fontName), 1],
+            /* fontRef = */ null,
+            operatorList,
+            task,
+            initialState,
+            /* fallbackFontDict = */ null,
+            /* cssFontInfo = */ cssFontInfo
+          )
+          .catch(function (reason) {
+            warn(`loadXfaFonts: "${reason}".`);
+            return null;
+          })
       );
     }
 
@@ -1369,13 +1378,28 @@ class PDFDocument {
         { name: "BoldItalic", fontWeight: 700, italicAngle: 12 },
       ]) {
         const name = `${missing}-${fontInfo.name}`;
+        const dict = getXfaFontDict(name);
 
         promises.push(
-          parseFont(name, getXfaFontDict(name), {
-            fontFamily: missing,
-            fontWeight: fontInfo.fontWeight,
-            italicAngle: fontInfo.italicAngle,
-          })
+          partialEvaluator
+            .handleSetFont(
+              resources,
+              [Name.get(name), 1],
+              /* fontRef = */ null,
+              operatorList,
+              task,
+              initialState,
+              /* fallbackFontDict = */ dict,
+              /* cssFontInfo = */ {
+                fontFamily: missing,
+                fontWeight: fontInfo.fontWeight,
+                italicAngle: fontInfo.italicAngle,
+              }
+            )
+            .catch(function (reason) {
+              warn(`loadXfaFonts: "${reason}".`);
+              return null;
+            })
         );
       }
     }
@@ -1384,16 +1408,7 @@ class PDFDocument {
     this.xfaFactory.appendFonts(pdfFonts, reallyMissingFonts);
   }
 
-  loadXfaResources(handler, task) {
-    return Promise.all([
-      this.#loadXfaFonts(handler, task).catch(() => {
-        // Ignore errors, to allow the document to load.
-      }),
-      this.#loadXfaImages(),
-    ]);
-  }
-
-  serializeXfaData(annotationStorage) {
+  async serializeXfaData(annotationStorage) {
     return this.xfaFactory
       ? this.xfaFactory.serializeData(annotationStorage)
       : null;

src/core/pdf_manager.js

@@ -95,6 +95,10 @@ class BasePdfManager {
     return this._docBaseUrl;
   }
 
+  get catalog() {
+    return this.pdfDocument.catalog;
+  }
+
   ensureDoc(prop, args) {
     return this.ensure(this.pdfDocument, prop, args);
   }
@@ -115,6 +119,18 @@ class BasePdfManager {
     return this.pdfDocument.fontFallback(id, handler);
   }
 
+  loadXfaFonts(handler, task) {
+    return this.pdfDocument.loadXfaFonts(handler, task);
+  }
+
+  loadXfaImages() {
+    return this.pdfDocument.loadXfaImages();
+  }
+
+  serializeXfaData(annotationStorage) {
+    return this.pdfDocument.serializeXfaData(annotationStorage);
+  }
+
   cleanup(manuallyTriggered = false) {
     return this.pdfDocument.cleanup(manuallyTriggered);
   }

src/core/struct_tree.js

@@ -118,7 +118,7 @@ class StructTreeRoot {
     pdfManager,
     changes,
   }) {
-    const root = await pdfManager.ensureCatalog("cloneDict");
+    const root = pdfManager.catalog.cloneDict();
     const cache = new RefSetCache();
     cache.put(catalogRef, root);
 

src/core/worker.js

@@ -170,11 +170,18 @@ class WorkerMessageHandler {
 
       const isPureXfa = await pdfManager.ensureDoc("isPureXfa");
       if (isPureXfa) {
-        const task = new WorkerTask("loadXfaResources");
+        const task = new WorkerTask("loadXfaFonts");
         startWorkerTask(task);
 
-        await pdfManager.ensureDoc("loadXfaResources", [handler, task]);
-        finishWorkerTask(task);
+        await Promise.all([
+          pdfManager
+            .loadXfaFonts(handler, task)
+            .catch(reason => {
+              // Ignore errors, to allow the document to load.
+            })
+            .then(() => finishWorkerTask(task)),
+          pdfManager.loadXfaImages(),
+        ]);
       }
 
       const [numPages, fingerprints] = await Promise.all([
@@ -610,9 +617,7 @@ class WorkerMessageHandler {
         }
 
         if (isPureXfa) {
-          promises.push(
-            pdfManager.ensureDoc("serializeXfaData", [annotationStorage])
-          );
+          promises.push(pdfManager.serializeXfaData(annotationStorage));
         } else {
           for (let pageIndex = 0; pageIndex < numPages; pageIndex++) {
             promises.push(

src/core/xfa/factory.js

@@ -43,7 +43,7 @@ class XFAFactory {
   }
 
   isValid() {
-    return !!(this.root && this.form);
+    return this.root && this.form;
   }
 
   /**

src/core/xfa/template.js

@@ -3412,7 +3412,8 @@ class Image extends StringObject {
       return HTMLResult.EMPTY;
     }
 
-    let buffer = this[$globalData].images?.get(this.href);
+    let buffer =
+      this[$globalData].images && this[$globalData].images.get(this.href);
     if (!buffer && (this.href || !this[$content])) {
       // In general, we don't get remote data and use what we have
       // in the pdf itself, so no picture for non null href.