Compare commits

..

No commits in common. "cd4a30341f048d722e06d078a94911cc19bfc3a6" and "00e3a4d87a22d92938687f7535bc35961a2a40e3" have entirely different histories.

6 changed files with 6 additions and 38 deletions

View File

@ -984,7 +984,6 @@ class HighlightEditor extends AnnotationEditor {
clipPathId, clipPathId,
}); });
editor.#addToDrawLayer(); editor.#addToDrawLayer();
editor.rotate(editor.parentRotation);
} }
return editor; return editor;

View File

@ -2674,34 +2674,4 @@ describe("Highlight Editor", () => {
); );
}); });
}); });
describe("Highlight must be rotated when existing in the pdf", () => {
let pages;
beforeAll(async () => {
pages = await loadAndWait("issue19424.pdf", ".annotationEditorLayer");
});
afterAll(async () => {
await closePages(pages);
});
it("must check that there is no scroll because of focus", async () => {
await Promise.all(
pages.map(async ([browserName, page]) => {
await page.evaluate(() => {
window.PDFViewerApplication.rotatePages(90);
});
await page.waitForSelector(
".annotationEditorLayer[data-main-rotation='90']"
);
await switchToHighlight(page);
await page.waitForSelector(
".canvasWrapper svg[data-main-rotation='90']"
);
})
);
});
});
}); });

View File

@ -713,4 +713,3 @@
!colors.pdf !colors.pdf
!red_stamp.pdf !red_stamp.pdf
!issue19633.pdf !issue19633.pdf
!issue19424.pdf

Binary file not shown.

View File

@ -187,10 +187,10 @@ class SignatureManager {
}, },
{ passive: true } { passive: true }
); );
this.#description.addEventListener( description.addEventListener(
"input", "input",
() => { () => {
this.#clearDescription.disabled = this.#description.value === ""; this.#clearDescription.disabled = description.value === "";
}, },
{ passive: true } { passive: true }
); );

View File

@ -716,9 +716,9 @@ See https://github.com/adobe-type-tools/cmap-resources
<div id="addSignatureControls"> <div id="addSignatureControls">
<div id="horizontalContainer"> <div id="horizontalContainer">
<div id="addSignatureDescriptionContainer"> <div id="addSignatureDescriptionContainer">
<label for="addSignatureDescInput" data-l10n-id="pdfjs-editor-add-signature-description-label"></label> <label for="addSignatureDescription" data-l10n-id="pdfjs-editor-add-signature-description-label"></span></label>
<span id="addSignatureDescription" class="inputWithClearButton"> <span id="addSignatureDescription" class="inputWithClearButton">
<input id="addSignatureDescInput" type="text" data-l10n-id="pdfjs-editor-add-signature-description-input" tabindex="0"></input> <input type="text" data-l10n-id="pdfjs-editor-add-signature-description-input" tabindex="0"></input>
<button class="clearInputButton" type="button" tabindex="0" aria-hidden="true"></button> <button class="clearInputButton" type="button" tabindex="0" aria-hidden="true"></button>
</span> </span>
</div> </div>
@ -755,9 +755,9 @@ See https://github.com/adobe-type-tools/cmap-resources
</div> </div>
<div id="editSignatureDescriptionAndView"> <div id="editSignatureDescriptionAndView">
<div id="editSignatureDescriptionContainer"> <div id="editSignatureDescriptionContainer">
<label for="editSignatureDescInput" data-l10n-id="pdfjs-editor-add-signature-description-label"></label> <label for="editSignatureDescription" data-l10n-id="pdfjs-editor-add-signature-description-label"></span></label>
<span id="editSignatureDescription" class="inputWithClearButton"> <span id="editSignatureDescription" class="inputWithClearButton">
<input id="editSignatureDescInput" type="text" data-l10n-id="pdfjs-editor-add-signature-description-input" tabindex="0"></input> <input type="text" data-l10n-id="pdfjs-editor-add-signature-description-input" tabindex="0"></input>
<button class="clearInputButton" type="button" tabindex="0" aria-hidden="true"></button> <button class="clearInputButton" type="button" tabindex="0" aria-hidden="true"></button>
</span> </span>
</div> </div>