5b368dd58a
(During rebasing of the previous patches I happened to look at the polyfills and noticed that this one could be removed now.) See: - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/toHex#browser_compatibility - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/toBase64#browser_compatibility - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/fromBase64#browser_compatibility Note that technically this functionality can still be disabled via a preference in Firefox, however that's slated for removal in [bug 1985120](https://bugzilla.mozilla.org/show_bug.cgi?id=1985120). Looking at the Firefox source-code, see https://searchfox.org/firefox-main/search?q=array.tobase64%28%29&path=&case=false®exp=false, you can see that it's already being used *unconditionally* elsewhere in the browser hence removing the polyfills ought to be fine (since toggling the preference would break other parts of the browser).
Font tests
The font tests check if PDF.js can read font data correctly. For validation
the ttx tool (from the Python fonttools library) is used that can convert
font data to an XML format that we can easily use for assertions in the tests.
In the font tests we let PDF.js read font data and pass the PDF.js-interpreted
font data through ttx to check its correctness. The font tests are successful
if PDF.js can successfully read the font data and ttx can successfully read
the PDF.js-interpreted font data back, proving that PDF.js does not apply any
transformations that break the font data.
Running the font tests
The font tests are run on GitHub Actions using the workflow defined in
.github/workflows/font_tests.yml, but it is also possible to run the font
tests locally. The current stable versions of the following dependencies are
required to be installed on the system:
- Python 3
fonttools(see https://pypi.org/project/fonttools and https://github.com/fonttools/fonttools)
The recommended way of installing fonttools is using pip in a virtual
environment because it avoids having to do a system-wide installation and
therefore improves isolation, but any other way of installing fonttools
that makes ttx available in the PATH environment variable also works.
Using the virtual environment approach the font tests can be run locally by
creating and sourcing a virtual environment with fonttools installed in
it before running the font tests:
python3 -m venv venv
source venv/bin/activate
pip install fonttools
npx gulp fonttest