Jonas Jenwald 74db085794 Re-factor how "internal" EventBus listeners are handled in the viewer ...

Currently the viewer uses semi-private `EventBus.prototype.{_on, _off}` methods, to try and ensure that all internal viewer state is updated *before* any "external" listeners are invoked.
For all use-cases outside of the viewer, e.g in the integration-tests, the `EventBus.prototype.{on, off}` methods are supposed to be used instead.

Unfortunately this isn't currently enforced in any way, except (hopefully) during review, and generally speaking it's not really possible to prevent the semi-private methods being used (e.g. by third-party users).
Hence this patch adds a new `INTERNAL_EVT` property which is *not* exposed anywhere (neither in the API nor globally), and whose value is generated at build-time, that the viewer uses to mark its `EventBus` listeners are internal.
This allows us to remove the semi-private `EventBus` methods, which helps to simplify that class a little bit.

2026-05-29 22:11:58 +02:00

..

images

Change the sidebar for a views manager

2025-12-15 17:43:52 +01:00

internal

Enable 'eslint-plugin-regexp' and fix existing findings

2026-05-25 14:31:55 +02:00

.gitignore

Support multiple wasm-files in the development viewer

2025-01-18 09:35:11 +01:00

alt_text_manager.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

annotation_editor_layer_builder.css

Make text selection more visible (bug 1879559)

2026-05-19 21:10:12 +02:00

annotation_editor_layer_builder.js

Move the PageViewport class into its own file

2026-05-16 12:31:40 +02:00

annotation_editor_params.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

annotation_layer_builder.css

[Editor] Change the icon for inline comments

2025-08-25 20:04:56 +02:00

annotation_layer_builder.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

app_options.js

Merge pull request #21308 from calixteman/bug2036265

2026-05-29 14:32:29 +02:00

app.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

autolinker.js

Enable 'eslint-plugin-regexp' and fix existing findings

2026-05-25 14:31:55 +02:00

base_download_manager.js

Convert the PDFObjects class to use a Map internally

2026-02-17 09:42:27 +01:00

base_pdf_page_view.js

Make text selection more visible (bug 1879559)

2026-05-19 21:10:12 +02:00

base_tree_viewer.js

Merge pull request #20742 from Snuffleupagus/tree-viewer-scrollIntoView

2026-03-01 13:01:21 +01:00

caret_browsing.js

Enable the radix ESLint rule

2026-04-25 12:13:12 +02:00

chrome-i18n-allow-access-to-file-urls.json

Add translations of "Allow access to file URLs"

2015-08-14 18:59:55 +02:00

chromecom.js

Enable 'eslint-plugin-regexp' and fix existing findings

2026-05-25 14:31:55 +02:00

comment_manager.css

Slightly move the resizer on the sidebar (bug 2019585)

2026-02-26 14:35:13 +01:00

comment_manager.js

Simplify the applyOpacity helper function

2026-03-29 14:52:06 +02:00

compressed.tracemonkey-pldi-09.pdf

Add Makefile. Move some files around to make building the website easier.

2011-07-05 10:53:57 -07:00

debugger.css

Add logic to track rendering area of various PDF ops

2025-08-22 18:26:59 +02:00

debugger.mjs

Add the possibility to skip some ops in the debug view

2026-03-15 22:25:45 +01:00

dialog.css

[Editor] Avoid to use similar colors for background and foreground colors in HCM (bug 1990082)

2025-09-24 17:04:27 +02:00

download_manager.js

Replace the IDownloadManager interface with an abstract BaseDownloadManager class

2026-02-01 17:56:03 +01:00

draw_layer_builder.css

Make text selection more visible (bug 1879559)

2026-05-19 21:10:12 +02:00

draw_layer_builder.js

Make text selection more visible (bug 1879559)

2026-05-19 21:10:12 +02:00

editor_undo_bar.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

event_utils.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

external_services.js

Remove the IL10n interface

2026-02-01 17:53:45 +01:00

firefox_print_service.js

Add a pref-controlled method to notify embedders that mozPrintCallback has completed (bug 2036265)

2026-05-25 15:42:19 +02:00

firefoxcom.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

generic_scripting.js

Switch to a wasm file for the quickjs sandbox

2026-04-23 22:34:48 +02:00

generic_signature_storage.js

Simplify Object.fromEntries usage a tiny bit in the web/generic_signature_storage.js file

2025-04-09 12:06:40 +02:00

genericcom.js

Add basic integration-tests for the PdfTextExtractor class

2026-05-20 17:26:50 +02:00

genericl10n.js

Remove the IL10n interface

2026-02-01 17:53:45 +01:00

grab_to_pan.js

Use the stopEvent helper function everywhere possible

2024-11-28 13:25:56 +01:00

internal_evt.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

l10n.js

Remove the IL10n interface

2026-02-01 17:53:45 +01:00

menu.css

Make sure the menuitems are readable when hovering them (bug 2023138)

2026-03-20 10:01:45 +01:00

menu.js

Correctly handle tab/page down when on a menu (bug 2016212)

2026-02-18 10:17:39 +01:00

message_bar.css

Use the light-dark CSS function in the viewer (issue 17780)

2025-04-23 15:31:39 +02:00

new_alt_text_manager.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

overlay_manager.js

Add a new closeIfActive method in the OverlayManager class

2025-02-14 15:43:00 +01:00

password_prompt.js

Add a new closeIfActive method in the OverlayManager class

2025-02-14 15:43:00 +01:00

pdf_attachment_viewer.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

pdf_cursor_tools.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

pdf_document_properties.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

pdf_find_bar.js

Enable the unicorn/prefer-class-fields ESLint plugin rule

2026-02-14 12:33:34 +01:00

pdf_find_controller.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

pdf_find_utils.js

Don't check for surrogates when verifying the chars to normalize

2026-02-26 16:46:34 +01:00

pdf_history.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

pdf_layer_viewer.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

pdf_link_service.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

pdf_outline_viewer.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

pdf_page_detail_view.js

Replace the IRenderableView interface with an abstract RenderableView class

2026-02-01 17:56:06 +01:00

pdf_page_view.js

Add support for Optional Content in the AnnotationLayer (issue 20433)

2026-05-23 12:33:56 +02:00

pdf_presentation_mode.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

pdf_print_service.js

Dont revoke blob URLs while printing but do it after

2026-04-08 14:04:09 +02:00

pdf_rendering_queue.js

Enable the unicorn/prefer-class-fields ESLint plugin rule

2026-02-14 12:33:34 +01:00

pdf_scripting_manager.component.js

Switch to a wasm file for the quickjs sandbox

2026-04-23 22:34:48 +02:00

pdf_scripting_manager.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

pdf_single_page_viewer.js

Remove the abstract BaseViewer-class

2022-09-08 12:38:17 +02:00

pdf_text_extractor.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

pdf_thumbnail_view.js

Move the PageViewport class into its own file

2026-05-16 12:31:40 +02:00

pdf_thumbnail_viewer.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

pdf_viewer.component.js

Replace the IRenderableView interface with an abstract RenderableView class

2026-02-01 17:56:06 +01:00

pdf_viewer.css

fix: inline styles for hidden helper elements

2026-05-14 14:28:41 +01:00

pdf_viewer.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

pdfjs.js

[api-minor] Move the getXfaPageViewport helper into the XfaLayer class

2026-05-16 12:31:53 +02:00

preferences.js

Stop pre-building the preference defaults, to simplify the build scripts

2026-01-30 13:26:19 +01:00

print_utils.js

[api-minor] Move the getXfaPageViewport helper into the XfaLayer class

2026-05-16 12:31:53 +02:00

renderable_view.js

Fix types to make "gulp typestest" succeeding

2026-02-13 22:34:04 +01:00

secondary_toolbar.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

sidebar.css

Slightly move the resizer on the sidebar (bug 2019585)

2026-02-26 14:35:13 +01:00

sidebar.js

Remove the "abort" listener, on the globalAbortSignal, in the web/sidebar.js file

2026-03-10 15:51:10 +01:00

signature_manager.css

[Editor] Make sure that doorhangers are large enough to fit localized strings

2025-07-15 17:14:44 +02:00

signature_manager.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

struct_tree_layer_builder.js

Update dependencies to the most recent versions

2026-04-12 16:16:21 +02:00

stubs-geckoview.js

Change the sidebar for a views manager

2025-12-15 17:43:52 +01:00

text_accessibility.js

[Annotation] Use the annotations rect in order to fix the order in the DOM (bug 1987914)

2025-10-09 17:43:49 +02:00

text_highlighter.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

text_layer_builder.css

Prevent inherited spacing from affecting text layer

2026-05-24 23:56:23 +05:00

text_layer_builder.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

toggle_button.css

Add a new linting task in order to detect unused/unknown css variables in the Firefox build

2025-12-08 09:44:33 +01:00

toolbar-geckoview.js

[GeckoView] Remove the open-in-app button (bug 1832519)

2024-03-04 19:32:12 +01:00

toolbar.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

tree.css

[api-minor] Update the minimum supported Google Chrome version to 118

2026-02-09 12:16:46 +01:00

ui_utils.js

Merge pull request #21330 from calixteman/fix_regex

2026-05-25 18:22:21 +02:00

view_history.js

Add a bit more validation in the ViewHistory constructor

2020-03-21 13:55:06 +01:00

viewer-geckoview.css

Add a new linting task in order to detect unused/unknown css variables in the Firefox build

2025-12-08 09:44:33 +01:00

viewer-geckoview.html

Add a Content-Security-Policy to pdf.js' viewer.html (bug 1960363)

2026-05-14 12:50:07 +02:00

viewer-geckoview.js

Replace the IRenderableView interface with an abstract RenderableView class

2026-02-01 17:56:06 +01:00

viewer-snippet-chrome-extension.html

Lint and format the HTML in using Prettier

2025-11-18 17:22:50 +01:00

viewer-snippet-chrome-overlays.html

Add a Content-Security-Policy to pdf.js' viewer.html (bug 1960363)

2026-05-14 12:50:07 +02:00

viewer-snippet-firefox-extension.html

[api-major] Output JavaScript modules in the builds (issue 10317)

2023-10-07 09:31:08 +02:00

viewer-snippet.html

Lint and format the HTML in using Prettier

2025-11-18 17:22:50 +01:00

viewer.css

Add a Content-Security-Policy to pdf.js' viewer.html (bug 1960363)

2026-05-14 12:50:07 +02:00

viewer.html

Allow inserting an image as a new page when editing a PDF

2026-05-28 22:11:13 +02:00

viewer.js

Add the UI for merging PDFs (bug 2028071)

2026-04-13 19:38:56 +02:00

views_manager.css

Allow merging a PDF by dropping it onto the thumbnail viewer

2026-05-20 18:06:55 +02:00

views_manager.js

Re-factor how "internal" EventBus listeners are handled in the viewer

2026-05-29 22:11:58 +02:00

xfa_layer_builder.css

Always render the Annotation- and XFA-layers with light color-scheme (issue 19871)

2025-04-26 20:44:07 +02:00

xfa_layer_builder.js

Shorten the XfaLayerBuilder.prototype.render method

2026-05-23 16:33:23 +02:00