From 20f3b6c4be87f865aa8cbbd40bba3333e8c8e2e2 Mon Sep 17 00:00:00 2001 From: Tim van der Meij Date: Fri, 31 May 2024 15:43:59 +0200 Subject: [PATCH] Use locally-installed Gulp over globally-installed one --- Benchmarking-your-changes.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Benchmarking-your-changes.md b/Benchmarking-your-changes.md index d8f30bc..4e100f8 100644 --- a/Benchmarking-your-changes.md +++ b/Benchmarking-your-changes.md @@ -21,8 +21,8 @@ When working on issues related to performance, it is important to provide a perf Run the following commands to create a 'baseline' measurement (i.e., before you make your changes): $ git checkout master - $ gulp generic - $ gulp components + $ npx gulp generic + $ npx gulp components $ cd test $ node test.mjs --statsFile=stats/results/baseline.json --statsDelay=5000 --manifestFile=benchmark.json @@ -30,8 +30,8 @@ Then apply your changes and create a 'current' measurement (replace ` - $ gulp generic - $ gulp components + $ npx gulp generic + $ npx gulp components $ cd test $ node test.mjs --statsFile=stats/results/current.json --statsDelay=5000 --manifestFile=benchmark.json @@ -70,7 +70,7 @@ When the test finishes there will be a section in the terminal with `------- Sum #### Apply Your Changes & Test Again 1. In the ``: 1. make your changes - 2. build `gulp mozcentral` + 2. run `npx gulp mozcentral` 3. copy the pdf.js build to firefox `rsync -a -v /build/mozcentral/browser/extensions/pdfjs/ toolkit/components/pdfjs/` 2. Back in ``: 1. Build firefox `./mach build faster`