mirror of
https://github.com/mozilla/pdf.js.git
synced 2026-07-09 00:25:51 +02:00
Updated Contributing (markdown)
parent
fec1601ae2
commit
c3ed24af4f
@ -136,8 +136,6 @@ git push origin {branch_name}
|
||||
### 6. Create pull request
|
||||
Create a pull request on GitHub for your feature branch. The code will then be reviewed and tested further by our contributors and the test bots.
|
||||
|
||||
Note that the translations for PDF.js in the `l10n` folder are synchronized with the Nightly branch of Mozilla Firefox. This means that we will only accept pull requests that add strings currently missing in the Nightly branch, but keep in mind that the changes will be overwritten when we synchronize again.
|
||||
|
||||
### 7. Code review and automated testing
|
||||
In addition to the GitHub pull request workflow, it is recommended that you communicate with the PDF.js team, for example via the [Matrix room](https://chat.mozilla.org/#/room/#pdfjs:mozilla.org). That will help to find a reviewer for your patch and speed up the review process. The reviewer will kick off further testing and do a code review.
|
||||
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user