Marmelator/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #19111 from calixteman/fix_highlight_test_with_kb

Browse Source 
Fix the highlight integration test when highlighting with the keyboard
This commit is contained in:
calixteman 2024-11-27 16:10:38 +01:00 committed by GitHub
commit 052b001f0e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
test/integration/highlight_editor_spec.mjs
View File

@ -697,7 +697,12 @@ describe("Highlight Editor", () => {
await page.keyboard.press("ArrowRight"); await page.keyboard.press("ArrowRight");
} }
await page.keyboard.press("ArrowDown"); await page.keyboard.press("ArrowDown");
await page.keyboard.press("ArrowDown"); // Here and elsewhere, we add a small delay between press and release
// to make sure that a keyup event for Shift is triggered after
// selectionchange (it's why adding the delay on the last before
// releasing shift is enough).
// It works with a value of 10ms, but we use 100ms to be sure.
await page.keyboard.press("ArrowDown", { delay: 100 });
await page.keyboard.up("Shift"); await page.keyboard.up("Shift");
await page.waitForSelector(sel); await page.waitForSelector(sel);
@ -1066,7 +1071,7 @@ describe("Highlight Editor", () => {
15 15
); );
await page.keyboard.down("Shift"); await page.keyboard.down("Shift");
await page.keyboard.press("ArrowDown"); await page.keyboard.press("ArrowDown", { delay: 100 });
await page.keyboard.up("Shift"); await page.keyboard.up("Shift");
await page.waitForSelector(getEditorSelector(0)); await page.waitForSelector(getEditorSelector(0));
@ -1715,7 +1720,7 @@ describe("Highlight Editor", () => {
); );
await page.keyboard.down("Shift"); await page.keyboard.down("Shift");
for (let i = 0; i < 3; i++) { for (let i = 0; i < 3; i++) {
await page.keyboard.press("ArrowDown"); await page.keyboard.press("ArrowDown", { delay: 100 });
} }
await page.keyboard.up("Shift"); await page.keyboard.up("Shift");
@ -1730,7 +1735,7 @@ describe("Highlight Editor", () => {
); );
await page.keyboard.down("Shift"); await page.keyboard.down("Shift");
for (let i = 0; i < 3; i++) { for (let i = 0; i < 3; i++) {
await page.keyboard.press("ArrowDown"); await page.keyboard.press("ArrowDown", { delay: 100 });
} }
await page.keyboard.up("Shift"); await page.keyboard.up("Shift");
await page.waitForSelector(getEditorSelector(1)); await page.waitForSelector(getEditorSelector(1));