Marmelator/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #18044 from calixteman/bug1894849

Browse Source 
Avoid to aria-hide the structure tree (bug 1894849)
This commit is contained in:
calixteman 2024-05-06 19:56:59 +02:00 committed by GitHub
commit 30d0e3a0ba
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/integration/accessibility_spec.mjs
View File

@ -31,6 +31,18 @@ describe("accessibility", () => {
await Promise.all( await Promise.all(
pages.map(async ([browserName, page]) => { pages.map(async ([browserName, page]) => {
await page.waitForSelector(".structTree"); await page.waitForSelector(".structTree");
const isVisible = await page.evaluate(() => {
let elem = document.querySelector(".structTree");
while (elem) {
if (elem.getAttribute("aria-hidden") === "true") {
return false;
}
elem = elem.parentElement;
}
return true;
});
expect(isVisible).withContext(`In ${browserName}`).toBeTrue();
// Check the headings match up. // Check the headings match up.
const head1 = await page.$eval( const head1 = await page.$eval(

1
web/pdf_page_view.js
View File

@ -908,7 +908,6 @@ class PDFPageView {
// overflow will be hidden in Firefox. // overflow will be hidden in Firefox.
const canvasWrapper = document.createElement("div"); const canvasWrapper = document.createElement("div");
canvasWrapper.classList.add("canvasWrapper"); canvasWrapper.classList.add("canvasWrapper");
canvasWrapper.setAttribute("aria-hidden", true);
this.#addLayer(canvasWrapper, "canvasWrapper"); this.#addLayer(canvasWrapper, "canvasWrapper");
if ( if (