Marmelator/pdf.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove the color-mix fallback used with PopupAnnotations

Browse Source 
This CSS feature is now available in *most* browsers that we support, with old Chromium-based browsers being the only exception; please see https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/color-mix#browser_compatibility

From this data we see that the feature in question has been supported since Chrome 111, which was released on 2023-03-01 (i.e. almost two years ago).

Please note that we've never guaranteed that all features and functionality will be available in the oldest supported browsers.
Furthermore, even with the `color-mix` fallback removed PopupAnnotations will still function just as before but may render with the default color (defined in the CSS-file) rather than the one specified in the PDF document.
This commit is contained in:
Jonas Jenwald 2025-02-02 10:24:26 +01:00
parent de191d2a12
commit 9f62a88c38
1 changed files with 1 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/display/annotation_layer.js
View File

@ -2199,23 +2199,7 @@ class PopupElement {
const baseColor = (popup.style.outlineColor = Util.makeHexColor( const baseColor = (popup.style.outlineColor = Util.makeHexColor(
...this.#color ...this.#color
)); ));
if ( popup.style.backgroundColor = `color-mix(in srgb, ${baseColor} 30%, white)`;
(typeof PDFJSDev !== "undefined" && PDFJSDev.test("MOZCENTRAL")) ||
CSS.supports("background-color", "color-mix(in srgb, red 30%, white)")
) {
popup.style.backgroundColor = `color-mix(in srgb, ${baseColor} 30%, white)`;
} else {
// color-mix isn't supported in some browsers hence this version.
// See https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/color-mix#browser_compatibility
// TODO: Use color-mix when it's supported everywhere.
// Enlighten the color.
const BACKGROUND_ENLIGHT = 0.7;
popup.style.backgroundColor = Util.makeHexColor(
...this.#color.map(c =>
Math.floor(BACKGROUND_ENLIGHT * (255 - c) + c)
)
);
}
} }
const header = document.createElement("span"); const header = document.createElement("span");