From 336073a2ada900a9aeb5a9d91b967aa6209341ac Mon Sep 17 00:00:00 2001 From: Tim van der Meij Date: Tue, 2 Jun 2020 23:54:30 +0200 Subject: [PATCH] Updated Benchmarking your changes (markdown) --- Benchmarking-your-changes.md | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/Benchmarking-your-changes.md b/Benchmarking-your-changes.md index 396184f..ffe95dc 100644 --- a/Benchmarking-your-changes.md +++ b/Benchmarking-your-changes.md @@ -16,24 +16,22 @@ When working on issues related to performance, it is important to provide a perf Run the following commands to create a 'baseline' measurement (i.e., before you make your changes): $ git checkout master - $ SKIP_BABEL=true gulp generic + $ gulp generic $ cd test - $ node test.js --browserManifestFile=resources/browser_manifests/browser_manifest.json \ - --statsFile=stats/results/baseline.json --statsDelay=5000 \ - --manifestFile=benchmark.json + $ node test.js --statsFile=stats/results/baseline.json --statsDelay=5000 --manifestFile=benchmark.json Then apply your changes and create a 'current' measurement (replace `` with the name of your branch): $ cd .. $ git checkout - $ SKIP_BABEL=true gulp generic + $ gulp generic $ cd test - $ node test.js --browserManifestFile=resources/browser_manifests/browser_manifest.json \ - --statsFile=stats/results/current.json --statsDelay=5000 \ - --manifestFile=benchmark.json + $ node test.js --statsFile=stats/results/current.json --statsDelay=5000 --manifestFile=benchmark.json Finally, you can compare the measurements and see any performance differences: $ node stats/statcmp.js stats/results/baseline.json stats/results/current.json -As a sanity check, you should do this twice with the same code and compare the results. \ No newline at end of file +As a sanity check, you should do this twice with the same code and compare the results. + +For faster benchmarking during development, it could be useful to pass the `--noChrome` command line parameter to `test.js` to skip Chrome and only test with Firefox. \ No newline at end of file